Re: The future of commit access policy for core Firefox

2017-03-13 Thread David Burns via governance
As the manager of the sheriffs, I am in favour of this proposal. The reasons why are as follow (and to note there are only 3 paid sheriffs to try cover the world): * A number of r+ with nits land up in the sheriffs queue for checkin-needed. This then puts the onus on the sheriffs, not the reviewe

Re: The future of commit access policy for core Firefox

2017-03-13 Thread Byron Jones via governance
David Burns wrote: We should try mitigate the security problem and fix our nit problem instead of bashing that we can't handle re-reviews because of nits. one way tooling could help here is to allow the reviewer to make minor changes to the patch before it lands. ie. "r+, fix typo in comment be

Re: The future of commit access policy for core Firefox

2017-03-13 Thread Ehsan Akhgari via governance
On 2017-03-12 4:53 PM, smaug wrote: > On 03/12/2017 10:40 PM, Ehsan Akhgari wrote: >> On 2017-03-11 9:23 AM, smaug via governance wrote: >>> On 03/11/2017 08:23 AM, Nicholas Nethercote wrote: On Sat, Mar 11, 2017 at 2:23 PM, smaug via governance < governance@lists.mozilla.org> wrote:

Re: The future of commit access policy for core Firefox

2017-03-13 Thread smaug via governance
A bit off topic On 03/13/2017 04:37 PM, David Burns wrote: Regarding burden on reviewers, the comments in this thread just highlight how broken our current process is by having to flag individual people for reviews. This leads to the a handful of people doing 50%+ of reviews on the code. Unfor

Re: New module: Gecko Profiler

2017-03-13 Thread Nicholas Nethercote via governance
Aftert explicit support from Adam and David and no objections, I have added this new module to https://wiki.mozilla.org/Modules. Nick On Thu, Mar 9, 2017 at 3:27 PM, Nicholas Nethercote wrote: > Greetings, > > The Gecko Profiler is a longstanding Mozilla component that has never had > its own m