Re: The future of commit access policy for core Firefox

2017-03-10 Thread Masatoshi Kimura via governance
On 2017/03/10 6:53, Mike Connor wrote: >- Two-factor auth must be a requirement for all users approving or >pushing a change. I have no mobile devices. How can I use 2FA? Previously I was suggested to buy a new PC and SSD only to shorten the build time. Now do I have to buy a smartphone o

Re: The future of commit access policy for core Firefox

2017-03-10 Thread smaug via governance
On 03/10/2017 12:59 AM, Bobby Holley wrote: At a high level, I think the goals here are good. However, the tooling here needs to be top-notch for this to work, and the standard approach of flipping on an MVP and dealing with the rest in followup bugs isn't going to be acceptable for something so

Re: The future of commit access policy for core Firefox

2017-03-10 Thread Eric Rescorla via governance
On Fri, Mar 10, 2017 at 7:23 PM, smaug via governance < governance@lists.mozilla.org> wrote: > On 03/10/2017 12:59 AM, Bobby Holley wrote: > >> At a high level, I think the goals here are good. >> >> However, the tooling here needs to be top-notch for this to work, and the >> standard approach of

Re: The future of commit access policy for core Firefox

2017-03-10 Thread smaug via governance
On 03/11/2017 05:23 AM, smaug wrote: On 03/10/2017 12:59 AM, Bobby Holley wrote: At a high level, I think the goals here are good. However, the tooling here needs to be top-notch for this to work, and the standard approach of flipping on an MVP and dealing with the rest in followup bugs isn't g

Re: The future of commit access policy for core Firefox

2017-03-10 Thread L. David Baron via governance
On Friday 2017-03-10 19:33 -0800, Eric Rescorla wrote: > We have been using Phabricator for our reviews in NSS and its interdiffs > work pretty well > (modulo rebases, which are not so great), and it's very easy to handle LGTM > with > nits and verify the nits. For what it's worth, I think proper

Re: The future of commit access policy for core Firefox

2017-03-10 Thread Nicholas Nethercote via governance
On Sat, Mar 11, 2017 at 2:23 PM, smaug via governance < governance@lists.mozilla.org> wrote: > > I'd be ok to do a quick r+ if interdiff was working well. Depending on the relative timezones of the reviewer and reviewee, that could delay landing by 24 hours or even a whole weekend. In general the