Re: [go-nuts] goimports no longer builds on go 1.4.2

2016-07-20 Thread Brad Fitzpatrick
Indeed, Go 1.4 is not supported. See https://github.com/golang/go/issues/16434 Patches are welcome, but since our CI doesn't test Go 1.4.x, the patch will likely rot. The workaround is to use an old version of goimports, but then you don't get its new toys. On Wed, Jul 20, 2016 at 8:00 AM, Samee

Re: [go-nuts] goimports no longer builds on go 1.4.2

2016-07-20 Thread Sameer Ajmani
+Brad Fitzpatrick On Wed, Jul 20, 2016 at 10:47 AM Jonathan Lawlor wrote: > Obviously 1.4.2 is quite out of date, but I thought it might be useful to > point out that the change https://go-review.googlesource.com/#/c/25001/ > added an import to runtime/trace, which is not a part of the 1.4.2 li

[go-nuts] goimports no longer builds on go 1.4.2

2016-07-20 Thread Jonathan Lawlor
Obviously 1.4.2 is quite out of date, but I thought it might be useful to point out that the change https://go-review.googlesource.com/#/c/25001/ added an import to runtime/trace, which is not a part of the 1.4.2 library, so go get golang.org/x/tools/cmd/goimports fails. Because goimports is in