Re: [go-nuts] best practices of client middleware

I haven’t written anything like that, I’m merely offering a suggestion on why the docs say not to do it. On 7 Mar 2018, at 09:28, eyal mailto:pose...@gmail.com>> wrote: In your tests in the round-trippers you do change the requests, as far as i can see. On Wed, Mar 7, 2018 at 10:13 AM Jakob B

Re: [go-nuts] best practices of client middleware

In your tests in the round-trippers you do change the requests, as far as i can see. On Wed, Mar 7, 2018 at 10:13 AM Jakob Borg wrote: > On 7 Mar 2018, at 08:07, Eyal Posener wrote: > > > > Very Nice stuff - shame he didn't merge it. > > But I see that you changes the request in the RoundTrip f

Re: [go-nuts] best practices of client middleware

On 7 Mar 2018, at 08:07, Eyal Posener wrote: > > Very Nice stuff - shame he didn't merge it. > But I see that you changes the request in the RoundTrip function, which is > claimed as forbidden in the docs. > Again, I don't understand why the docs forbid it… I expect that this is so that the use

[go-nuts] best practices of client middleware

Hi I want to implement a client middleware - for example: sign the request body and add the signature as an HTTP header. I thought that the best way to do it is to implement a RoundTripper interface which up on request, calculate the signature, ad