Re: [go-nuts] TotalAlloc dropped in runtime/metrics

2021-04-29 Thread 'Michael Knyszek' via golang-nuts
Hi Marco, https://go-review.googlesource.com/c/go/+/312431 just landed and should resolve the issue for Go 1.17. On Tue, Apr 20, 2021 at 3:28 PM Michael Knyszek wrote: > Oh, actually, you can compute Mallocs and Frees from allocs-by-size and > frees-by-size (summing the total # of samples). You

Re: [go-nuts] TotalAlloc dropped in runtime/metrics

2021-04-21 Thread Marco A.
Thanks Michael, do not worry about TotalAlloc.. we do have that metric to replace somehow but we might even think about dropping it completely. I was honestly wondering if TotalAlloc (cumulative bytes allocated for heap objects) is a useful metric to have at all since Go uses garbage collection

Re: [go-nuts] TotalAlloc dropped in runtime/metrics

2021-04-20 Thread 'Michael Knyszek' via golang-nuts
Oh, actually, you can compute Mallocs and Frees from allocs-by-size and frees-by-size (summing the total # of samples). You can only estimate TotalAlloc though, which is genuinely missing. On Tue, Apr 20, 2021 at 3:14 PM Michael Knyszek wrote: > Oh gosh, I think TotalAlloc, Mallocs, and Frees ar

Re: [go-nuts] TotalAlloc dropped in runtime/metrics

2021-04-20 Thread 'Michael Knyszek' via golang-nuts
Oh gosh, I think TotalAlloc, Mallocs, and Frees are actually an oversight on my part. Sorry about that. They're very easy to add and I can probably even add them for this release. Please do use the new runtime/metrics package! Most of the other metrics should be there in some form (e.g. the divis

Re: [go-nuts] TotalAlloc dropped in runtime/metrics

2021-04-20 Thread Ian Lance Taylor
[ + mknyszek ] On Tue, Apr 20, 2021 at 11:12 AM Marco A. wrote: > > Hi everyone, > > I was considering using the new stable metrics interface with go 1.16 > (https://golang.org/pkg/runtime/metrics/) for our program and I was also > wondering why things like TotalAlloc > (https://golang.org/pkg

[go-nuts] TotalAlloc dropped in runtime/metrics

2021-04-20 Thread Marco A.
Hi everyone, I was considering using the new stable metrics interface with go 1.16 (https://golang.org/pkg/runtime/metrics/) for our program and I was also wondering why things like TotalAlloc (https://golang.org/pkg/runtime/#MemStats) had been dropped in the available metrics. Any particular