Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread 'Axel Wagner' via golang-nuts
There is exactly one instance of "package local sub-packages" and that is internal packages (okay. And arguably vendoring). For everything else, the same logic applies. I don't find it too much to ask in that case, to actually and explicitly fork. On Fri, Nov 25, 2016 at 1:27 PM, Mariusz Gronczews

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread Mariusz Gronczewski
I'm fine with namespacing and I see benefits for it for deps, just it would be nice to have something inbetween absolute path and "../../something" (like "$ROOT/packagename") for package-local "subpackages" that are not designed to be standalone ones (like in my case it is usually a package holding

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread 'Axel Wagner' via golang-nuts
I think it's reasonable to expect you to set up your GOPATH accordingly, if you want the layout to be internal and specific and deviating from the discovery mechanism. There is no reason, why a tool couldn't fetch your internal git-repository to the subpath of $GOPATH that corresponds to your publi

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread Mariusz Gronczewski
On Friday, November 25, 2016 at 12:10:56 PM UTC+1, Axel Wagner wrote: > > It is pretty simple: > > * If you actually *fork* a project (not what github calls a "fork", but > "create a repo with a different set of maintainers"), *that is a different > package*. It will contain different code and

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread 'Axel Wagner' via golang-nuts
It is pretty simple: * If you actually *fork* a project (not what github calls a "fork", but "create a repo with a different set of maintainers"), *that is a different package*. It will contain different code and have a different mantainer. So it is a feature, that go get won't work on it OOTB. To

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread Mariusz Gronczewski
But then go get github.com/me/project will be non-functional ? 2016-11-25 11:35 GMT+01:00 Ian Davis : > This is how to do it with a git repository: > > http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html > > > On Fri, Nov 25, 2016, at 10:31 AM, Mariusz Gronczewski wrote: >

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread Jan Mercl
On Fri, Nov 25, 2016 at 11:31 AM Mariusz Gronczewski wrote: > If I just go and fork it and do a bunch of changes across packages then I can't test it because everything will be under "github.com/me/project" so deps will come from the "wrong" place. 1. Fork it on githug. 2. $ mkdir -p $GOPATH/src

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread Sebastien Binet
On Fri, Nov 25, 2016 at 11:31 AM, Mariusz Gronczewski wrote: > Hi, > > So let's say there is a project, living under path > github.com/local/project. Project is neatly divided into a bunch of > packages and uses recommended absolute paths: > > package main > > import ( > "github.com/external/dep1

Re: [go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread Ian Davis
This is how to do it with a git repository: http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html On Fri, Nov 25, 2016, at 10:31 AM, Mariusz Gronczewski wrote: > Hi, > > So let's say there is a project, living under path > github.com/local/project. Project is neatly

[go-nuts] So how exactly one does(should do) forking/pull requests in Golang world

2016-11-25 Thread Mariusz Gronczewski
Hi, So let's say there is a project, living under path github.com/local/project. Project is neatly divided into a bunch of packages and uses recommended absolute paths: package main import ( "github.com/external/dep1" "github.com/local/project/config" "github.com/local/project/backend" "github