Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-06 Thread t hepudds
FWIW, I think this issue tracks a similar request: #30515 cmd/go: offer a consistent "global install" command https://github.com/golang/go/issues/30515 It was tagged as a release-blocker for Go 1.13, but I think time ran out. One outcome considered there was a new argument to 'go get' su

Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread Dan Kortschak
I also. We have to add additional mess to our build scripts when we get testing dependencies that are not part of our distribution to avoid contaminating the go.{mod,sum} in the repo root. This has repeatedly been a source of irritation and frustration. Dan On Thu, 2019-09-05 at 11:36 -0700, Mi

Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread Michael Ellis
> current directory is. But if the current directory happens to be > inside a module, the user inadvertently also performed (1). Thanks, Mihai. That sounds like a consistent explanation. I'm going to try creating a new junk project to see if I can reproduce the problem. Unfortunately, I'm going t

Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread Mihai Borobocea
On Thu, Sep 5, 2019 at 10:18 PM Jan Mercl <0xj...@gmail.com> wrote: > `go get` should do just one thing and do it well. Automagically > adjusting `go.mod` if one is found in the current directory (or in any > of its parents) when outside $GOPATH is IMO neither of that. Or it > should be enabled by

Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread Jan Mercl
On Thu, Sep 5, 2019 at 8:51 PM Mihai Borobocea wrote: > $ go help module-get > The 'go get' command changes behavior depending on whether the > go command is running in module-aware mode or legacy GOPATH mode. > … > Get resolves and adds dependencies to the current development module > and then b

Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread Mihai Borobocea
On Thu, Sep 5, 2019 at 9:22 PM Jan Mercl <0xj...@gmail.com> wrote: > > > Running 'go get ...' inside a module can add indirect dependencies to > > go.mod. > > I'm surprised. There's probably some rationale behind `go get` having > such side effects. Can anyone please shed some light on this? $ go

Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread Michael Ellis
I second Jan's request for light-shedding. It's one thing to add real indirect dependencies. I can sort of understand that. Can't think of a sensible reason for adding dependencies that are unrelated to the code in the module. On Thursday, September 5, 2019 at 2:23:11 PM UTC-4, Jan Mercl wro

Re: [go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread Jan Mercl
On Thu, Sep 5, 2019 at 8:18 PM wrote: > Running 'go get ...' inside a module can add indirect dependencies to go.mod. I'm surprised. There's probably some rationale behind `go get` having such side effects. Can anyone please shed some light on this? -- You received this message because you are

[go-nuts] Re: v1.13: Altered go.mod file in project after updating vim-go binaries

2019-09-05 Thread mihaibopublic
On Thursday, September 5, 2019 at 8:48:11 PM UTC+3, Michael Ellis wrote: > > I ran :GoUpdateBinaries. > > When I looked at git status, I saw that the go.mod and go.sum files had > changed. My go.mod now contains lines for all vim-go dependencies! > Running 'go get example.com/some/module' in