[go-nuts] Re: request for feedback: another websocket server implementation

2019-09-18 Thread Ilia Choly
You're absolutely right. Disregard my comment. On Wednesday, September 18, 2019 at 1:10:38 PM UTC-4, Jochen Voss wrote: > > Dear Ilia, > > Thank you for your comment. In my mind, Read and Write are made for > streaming data, whereas a websocket connection transports messages. How > would I han

[go-nuts] Re: request for feedback: another websocket server implementation

2019-09-18 Thread Jochen Voss
Dear Ilia, Thank you for your comment. In my mind, Read and Write are made for streaming data, whereas a websocket connection transports messages. How would I handle message types and message boundaries when using the io.Reader and io.Writer interfaces? (I do try to implement these interfac

[go-nuts] Re: request for feedback: another websocket server implementation

2019-09-18 Thread Jochen Voss
Dear T L, Thanks for this. I was aware of implementations number 1 and 4 (and I think I like my own better than these), but I didn't spot numbers 2 and 3. I'll have a look at these, too. Many thanks, Jochen On Wednesday, 18 September 2019 14:27:17 UTC+1, T L wrote: > > Just for reference. He

[go-nuts] Re: request for feedback: another websocket server implementation

2019-09-18 Thread Ilia Choly
You should try to make Conn implement io.Reader and io.Writer On Tuesday, September 17, 2019 at 6:29:08 PM UTC-4, Jochen Voss wrote: > > Dear all, > > Because I wanted to learn about the websocket protocol, I have implemented > a websocket server in Go: > > code: https://github.com/seehuhn/go

[go-nuts] Re: request for feedback: another websocket server implementation

2019-09-18 Thread T L
Just for reference. Here are other Go websocket implementations: * Gorilla WebSocket https://github.com/gorilla/websocket * https://github.com/nhooyr/websocket * https://github.com/gobwas/ws * x/net/websocket https://godoc.org/golang.org/x/net/websocket On Tuesday, September 17, 2019 at 6:29:08 PM