[go-nuts] Re: http client for go-server-timing

2018-02-26 Thread Eyal Posener
Thanks for the CR Matt, that's very kind of you. About the factory, I thought that some of the options would be sometimes easier to define in construction time, and copy the object doesn't add complexity to my opinion. About two sets of optoins, except of the "WithName" option, there is no "ti

[go-nuts] Re: http client for go-server-timing

2018-02-26 Thread matthewjuran
Hi Eyal, here’s a code review. Perhaps there’s a simpler name? Something like “timing.Timer” would look better than “clienttiming.Timer”. return fmt.Sprintf("%s %s", req.Method, req.URL.Path) could just be return req.Method + “ “ + req.URL.Path which removes the package fmt dependency. The g