[go-nuts] Re: Fully-qualified import paths and Pull Requests

Thanks for correcting my concerns! On Thursday, May 4, 2017 at 8:52:02 PM UTC-7, Dave Cheney wrote: > > > > On Friday, 5 May 2017 13:37:26 UTC+10, st ov wrote: >> >> By "fork" I mean in the GItHub sense, the forking of original project >> *github.com/original/foo >>

[go-nuts] Re: Fully-qualified import paths and Pull Requests

On Friday, 5 May 2017 13:37:26 UTC+10, st ov wrote: > > By "fork" I mean in the GItHub sense, the forking of original project > *github.com/original/foo > * through their console so that > *github.com/me/foo > * is created. > > And "cl

[go-nuts] Re: Fully-qualified import paths and Pull Requests

By "fork" I mean in the GItHub sense, the forking of original project *github.com/original/foo* through their console so that *github.com/me/foo* is created. And "clone" would be running "git clone https://github.com/original/foo.git"; on my local machine so I have a local copy of the original

[go-nuts] Re: Fully-qualified import paths and Pull Requests

This discussion could get confusing if we're not clear about our terms. Could you please describe what the terms cloned and forked mean to you. -- You received this message because you are subscribed to the Google Groups "golang-nuts" group. To unsubscribe from this group and stop receiving ema

[go-nuts] Re: Fully-qualified import paths and Pull Requests

Should the source repo be cloned or forked first? Or does it not matter? I was thinking there could be an issue with someone pushing a change after its cloned but before its forked. On Tuesday, May 2, 2017 at 11:55:41 PM UTC-7, Nathan Kerr wrote: > > http://blog.sgmansfield.com/2016/06/working-

Re: [go-nuts] Re: Fully-qualified import paths and Pull Requests

Thanks! That clears it up. On Wednesday, May 3, 2017 at 7:52:58 AM UTC-7, Axel Wagner wrote: > > Yes, that would be the correct approach. And yes, the fork wouldn't be > go-gettable, but it isn't supposed to be long-lived or go-got anyway; it's > a fork to do a pull-request. > If you want to do

Re: [go-nuts] Re: Fully-qualified import paths and Pull Requests

Yes, that would be the correct approach. And yes, the fork wouldn't be go-gettable, but it isn't supposed to be long-lived or go-got anyway; it's a fork to do a pull-request. If you want to do an actual fork (not what github calls a fork, but what the open source community calls a fork), you are cr

[go-nuts] Re: Fully-qualified import paths and Pull Requests

In reading deeper, is the post saying to put my fork at the canonical path locally. So I'd clone my fork, *github.com/me/foo* to *github.com/original/foo* *locally* But setup the git remote to push to *github.com/me/foo* Then locally, I would use the fully-qualified import path of import ( "g

[go-nuts] Re: Fully-qualified import paths and Pull Requests

Thanks, if I read that right the post just rehashes the workflow for working with remotes with git and go get. The question I have concerns the import path in the code. If I fork, *github.com/original/foo* clone it locally to, *github.com/me/foo* Add *github.com/me/foo/internal/bar/bar.go* and t

[go-nuts] Re: Fully-qualified import paths and Pull Requests

Thanks! Alright, i need to test that, im not used to HG, bzr. Kind of forgotten about svn (:/) meanwhile, https://github.com/mh-cbon/fork On Wednesday, May 3, 2017 at 12:19:07 PM UTC+2, Dave Cheney wrote: > > You can simulate this with most source control systems by manually > checking out y

[go-nuts] Re: Fully-qualified import paths and Pull Requests

You can simulate this with most source control systems by manually checking out your fork in the original location. Say hg clone https://bitbucket.org/davecheney/pkg $GOPATH/src/bitbucket.org/project/pkg -- You received this message because you are subscribed to the Google Groups "golang-nut

[go-nuts] Re: Fully-qualified import paths and Pull Requests

Do you have any idea how that d work with other vcs ? On Wednesday, May 3, 2017 at 8:55:41 AM UTC+2, Nathan Kerr wrote: > > http://blog.sgmansfield.com/2016/06/working-with-forks-in-go/ gives some > good pointers on how to do this. -- You received this message because you are subscribed to th