> suggests you should move the wg.Add(1) out of the Goroutine from here:
[...]
> to there
Thanks, that's an actual bug.
> * Do you happen to know about the context package? It seems like a lot of
> the closedown can happen if you recast part of the system as contexts and
> cancel those explicit
The documentation for
https://golang.org/pkg/sync/#WaitGroup.Add
suggests you should move the wg.Add(1) out of the Goroutine from here:
https://github.com/Vivena/babelweb2/blob/03d03818e125f6f34c3b323b6cba786075888c00/main.go#L63
to there
https://github.com/Vivena/babelweb2/blob/03d03818e125f6
> How did your students adjust to working with the GOPATH?
No issue at all. I told them to create a directory under ~/go/src, and
that was it.
> It seems to cause some people trouble.
In my experience, undergraduate students accept pretty much anything if
the instructions you give them are clea
Hi Juliusz,
How did your students adjust to working with the GOPATH? I'm always
interested to see how newcomers react to it. It seems to cause some people
trouble.
On Sun, Jul 30, 2017, 12:14 PM Juliusz Chroboczek wrote:
> > I glanced at babelweb2 (https://github.com/Vivena/babelweb2/). A code
> I glanced at babelweb2 (https://github.com/Vivena/babelweb2/). A code
> review would be useful. For example, from parser/parser.go:
Thanks for the review. As I've mentioned, neither the students nor me
had any significant experience with Go, so we were learning as we went
along.
If you happen
Juliusz,
Thank you. That's very interesting.
Code should be correct, maintainable, robust, readable, and reasonably
efficient. Readablity is a prerequisite for the other properties.
I glanced at babelweb2 (https://github.com/Vivena/babelweb2/). A code
review would be useful. For example, from
