Re: [go-nuts] New Go API for protobuf

2020-04-17 Thread Tharaneedharan Vilwanathan
Hi, In GRPC examples, I deleted helloworld.pb.go and recreated it (after installing protoc-gen-go from "google.golang.org/protobuf" cmd): xx:~/gopath/src/google.golang.org/grpc/examples/helloworld$ cd helloworld/ xx:~/gopath/src/google.golang.org/grpc/examples/helloworld/helloworld$ *protoc --go_

Re: [go-nuts] New Go API for protobuf

2020-04-17 Thread Tharaneedharan Vilwanathan
Thank you all for the response. I changed the version to 1.4.0 for protobuf in grpc. I think it works fine but it also looked like if I attempt to regenerate .pb.go file for the "helloworld" example of grpc, it didn't quite seem to work. I will try it again a bit later. Regards dharani On Mon, Ap

Re: [go-nuts] New Go API for protobuf

2020-04-13 Thread thebrokentoaster
In terms of whether the public API needs to change in light of the new protobuf API, the only place that the old protobuf API leaks to the public grpc API is here: https://pkg.go.dev/google.golang.org/grpc/credentials?tab=doc#OtherChannelzSecurityValue (where it uses the old proto.Message defi

Re: [go-nuts] New Go API for protobuf

2020-04-13 Thread thebrokentoaster
As of right now, grpc is on github.com/golang/protobuf@v1.3.3 . However, nothing stops you in your specific application to upgrade to github.com/golang/protobuf@v1.4.0, which just a thin wrapper over the

Re: [go-nuts] New Go API for protobuf

2020-04-13 Thread Ian Lance Taylor
[ + joetsai ] On Mon, Apr 13, 2020 at 3:41 PM Tharaneedharan Vilwanathan wrote: > > Hi, > > I have a quick question. > > I was going through this: > https://blog.golang.org/protobuf-apiv2 > > I would like to know if grpc is using this new version. To the extent I > tried, it seemed to use the ol

[go-nuts] New Go API for protobuf

2020-04-13 Thread Tharaneedharan Vilwanathan
Hi, I have a quick question. I was going through this: https://blog.golang.org/protobuf-apiv2 I would like to know if grpc is using this new version. To the extent I tried, it seemed to use the old API. Am I right? If so, how do I make grpc use the new API? Or am I missing something? Please let