Re: [go-nuts] Importing non-module based code

Thanks. Make sense. > On Jul 16, 2024, at 9:00 AM, Jan Mercl <0xj...@gmail.com> wrote: > > On Tue, Jul 16, 2024 at 3:57 PM Robert Engels wrote: > >> Yes, I just added that tag and pushed it, but @latest wouldn’t pick it up >> for some reason, needed to specify the release exactly using @v0.3.1

Re: [go-nuts] Importing non-module based code

On Tue, Jul 16, 2024 at 3:57 PM Robert Engels wrote: > Yes, I just added that tag and pushed it, but @latest wouldn’t pick it up for > some reason, needed to specify the release exactly using @v0.3.1 @latest is the "latest" known to the proxy server. It has some varying delay to update. -- Yo

Re: [go-nuts] Importing non-module based code

I have go 1.21 specified in the go.mod, but I don’t think that mattered. I added a tag to include my changes to my gocui and pushed (still did not add a go mod there), and it seems to work if I specify the tagged version - @latest did not pick it up, but maybe that uses the central registry whic

Re: [go-nuts] Importing non-module based code

Yes, I just added that tag and pushed it, but @latest wouldn’t pick it up for some reason, needed to specify the release exactly using @v0.3.1 > On Jul 16, 2024, at 8:55 AM, Jan Mercl <0xj...@gmail.com> wrote: > > On Tue, Jul 16, 2024 at 3:50 PM Robert Engels wrote: >> >> Weird, even after I a

Re: [go-nuts] Importing non-module based code

On Tue, Jul 16, 2024 at 3:50 PM Robert Engels wrote: > > Weird, even after I added the tag, using @latest did not pull the latest > code, I needed to specify the tag specifically @v0.3.1 I think I see the exported identifiers you need in v0.3.1, published 2018: https://pkg.go.dev/github.com/rob

Re: [go-nuts] Importing non-module based code

You don't mention what version of Go you're using but, note from the Go 1.22 release notes: > go get is no longer supported outside of a module in the legacy GOPATH mode (that is, with GO111MODULE=off). Other build commands, such as go build and go test, will continue to work indefinitely for l

Re: [go-nuts] Importing non-module based code

Weird, even after I added the tag, using @latest did not pull the latest code, I needed to specify the tag specifically @v0.3.1 > On Jul 16, 2024, at 8:48 AM, Robert Engels wrote: > > Thanks. Yea, because it needs a later tag now. I guess it never compiled > after I changed go-trader to use mo

Re: [go-nuts] Importing non-module based code

Thanks. Yea, because it needs a later tag now. I guess it never compiled after I changed go-trader to use modules. > On Jul 16, 2024, at 8:47 AM, Jan Mercl <0xj...@gmail.com> wrote: > > On Tue, Jul 16, 2024 at 3:41 PM 'Robert Engels' via golang-nuts > wrote: > >> The go get works, and the code

Re: [go-nuts] Importing non-module based code

On Tue, Jul 16, 2024 at 3:41 PM 'Robert Engels' via golang-nuts wrote: > The go get works, and the code is there, but it isn’t seeing my code - it > seems like it is using the original gocui which has since added module > support. > > cmd/client/main.go:43:7: gui.Update undefined (type *gocui.G

Re: [go-nuts] Importing non-module based code

I think I figured it out. I need to create a tag I guess? Since @latest doesn’t pull head ? This seems to have changed, because I “think” this used to compile fine. > On Jul 16, 2024, at 8:40 AM, 'Robert Engels' via golang-nuts > wrote: > > Has it changed so that Go repo that imports a from

[go-nuts] Importing non-module based code

Has it changed so that Go repo that imports a from another repo that doesn’t use modules no longer works? Maybe a recent change? I have a repo github.com/robaho/go-trader that imports githut.com/robaho/gocui (which is a fork