Re: [go-nuts] net/smtp Client.hello() returns a single error and drops the ehlo error entirely

Should I perhaps create a github issue to address this? On Friday, July 1, 2016 at 3:16:24 PM UTC-6, Ian Lance Taylor wrote: > > On Fri, Jul 1, 2016 at 1:17 PM, 'Matthew Altman' via golang-nuts > > wrote: > > https://github.com/golang/go/blob/master/src/net/smtp/sm

Re: [go-nuts] net/smtp Client.hello() returns a single error and drops the ehlo error entirely

Jul 1, 2016 at 3:16 PM, Ian Lance Taylor wrote: > On Fri, Jul 1, 2016 at 1:17 PM, 'Matthew Altman' via golang-nuts > wrote: > > https://github.com/golang/go/blob/master/src/net/smtp/smtp.go#L76-L79 > > > > This method can make two distinct SMTP calls. First an EHLO a

[go-nuts] net/smtp Client.hello() returns a single error and drops the ehlo error entirely

https://github.com/golang/go/blob/master/src/net/smtp/smtp.go#L76-L79 This method can make two distinct SMTP calls. First an EHLO and then a HELO. If the EHLO fails it attempts HELO. However, if the connection was closed remotely after EHLO the HELO will of course also fail but the error message

[go-nuts] net/smtp Client.hello() prematurely sets didHello

When calling Client.hello(), and the smtp server returns a failure code (this can be reproduced via postfix smtp-sink and a flag of -r HELO,EHLO) another attempt at a Hello is not possible. https://github.com/golang/go/blob/master/src/net/smtp/smtp.go#L75 shows that the didHello flag is set bef