Re: [go-nuts] might be a hole in Golang specification regarding the definition of "addressable"

2024-07-16 Thread 'Axel Wagner' via golang-nuts
Hi, > However, I would like to point out that selector rule 3 states: > > As an exception, if the type of x is a defined pointer type and (*x).f is > a valid selector expression denoting a field (but not a method), then x.f > is shorthand for (**x).f.* > > The emphasis here is on "defined pointer

Re: [go-nuts] might be a hole in Golang specification regarding the definition of "addressable"

2024-07-16 Thread 王旭东
Hi Ian, Axel (Glad to see you here;-) Thank you for your quick explanation. However, I would like to point out that selector rule 3 states: As an exception, if the type of x is a defined pointer type and (*x).f is a valid selector expression denoting a field (but not a method), then x.f is s

Re: [go-nuts] might be a hole in Golang specification regarding the definition of "addressable"

2024-07-16 Thread 'Axel Wagner' via golang-nuts
Oh, I only just realized that "pointer indirection" is literally in that list of addressable things. For some reason I have overlooked that, even after re-reading the section of the spec several times. That really makes this clear. On Wed, 17 Jul 2024 at 06:51, Ian Lance Taylor wrote: > On Tue,

Re: [go-nuts] might be a hole in Golang specification regarding the definition of "addressable"

2024-07-16 Thread Ian Lance Taylor
On Tue, Jul 16, 2024 at 9:29 PM 王旭东 wrote: > > Hi, I have a question about "addressable." > > The following code illustrates my question (see the comments): > https://go.dev/play/p/xpiPXuEqh0O?v=gotip > > > > I also posted question in the Gopher Slack channel, and @Axel Wagner provided > a detail

[go-nuts] might be a hole in Golang specification regarding the definition of "addressable"

2024-07-16 Thread 王旭东
Hi, I have a question about "addressable." The following code illustrates my question (see the comments): https://go.dev/play/p/xpiPXuEqh0O?v=gotip I also posted question in the Gopher Slack channel, and @Axel Wagner provided

[go-nuts] I Published My first Go Package

2024-07-16 Thread Kerem Mert
Hey, I published my first go package. With this package, you can create a linked list and manage it. To review the package and contribute: https://pkg.go.dev/github.com/kerem37mert/linkedlist https://github.com/kerem37mert/linkedlist -- You received this message because you are subscribed t

[go-nuts] Go 1.23 Release Candidate 2 is released

2024-07-16 Thread announce
Hello gophers, We have just released go1.23rc2, a release candidate version of Go 1.23. It is cut from release-branch.go1.23 at the revision tagged go1.23rc2. Please try your production load tests and unit tests with the new version. Your help testing these pre-release versions is invaluable. Re

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread 'Robert Engels' via golang-nuts
Thanks. Make sense. > On Jul 16, 2024, at 9:00 AM, Jan Mercl <0xj...@gmail.com> wrote: > > On Tue, Jul 16, 2024 at 3:57 PM Robert Engels wrote: > >> Yes, I just added that tag and pushed it, but @latest wouldn’t pick it up >> for some reason, needed to specify the release exactly using @v0.3.1

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread Jan Mercl
On Tue, Jul 16, 2024 at 3:57 PM Robert Engels wrote: > Yes, I just added that tag and pushed it, but @latest wouldn’t pick it up for > some reason, needed to specify the release exactly using @v0.3.1 @latest is the "latest" known to the proxy server. It has some varying delay to update. -- Yo

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread robert engels
I have go 1.21 specified in the go.mod, but I don’t think that mattered. I added a tag to include my changes to my gocui and pushed (still did not add a go mod there), and it seems to work if I specify the tagged version - @latest did not pick it up, but maybe that uses the central registry whic

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread 'Robert Engels' via golang-nuts
Yes, I just added that tag and pushed it, but @latest wouldn’t pick it up for some reason, needed to specify the release exactly using @v0.3.1 > On Jul 16, 2024, at 8:55 AM, Jan Mercl <0xj...@gmail.com> wrote: > > On Tue, Jul 16, 2024 at 3:50 PM Robert Engels wrote: >> >> Weird, even after I a

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread Jan Mercl
On Tue, Jul 16, 2024 at 3:50 PM Robert Engels wrote: > > Weird, even after I added the tag, using @latest did not pull the latest > code, I needed to specify the tag specifically @v0.3.1 I think I see the exported identifiers you need in v0.3.1, published 2018: https://pkg.go.dev/github.com/rob

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread Jason Phillips
You don't mention what version of Go you're using but, note from the Go 1.22 release notes: > go get is no longer supported outside of a module in the legacy GOPATH mode (that is, with GO111MODULE=off). Other build commands, such as go build and go test, will continue to work indefinitely for l

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread 'Robert Engels' via golang-nuts
Weird, even after I added the tag, using @latest did not pull the latest code, I needed to specify the tag specifically @v0.3.1 > On Jul 16, 2024, at 8:48 AM, Robert Engels wrote: > > Thanks. Yea, because it needs a later tag now. I guess it never compiled > after I changed go-trader to use mo

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread 'Robert Engels' via golang-nuts
Thanks. Yea, because it needs a later tag now. I guess it never compiled after I changed go-trader to use modules. > On Jul 16, 2024, at 8:47 AM, Jan Mercl <0xj...@gmail.com> wrote: > > On Tue, Jul 16, 2024 at 3:41 PM 'Robert Engels' via golang-nuts > wrote: > >> The go get works, and the code

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread Jan Mercl
On Tue, Jul 16, 2024 at 3:41 PM 'Robert Engels' via golang-nuts wrote: > The go get works, and the code is there, but it isn’t seeing my code - it > seems like it is using the original gocui which has since added module > support. > > cmd/client/main.go:43:7: gui.Update undefined (type *gocui.G

Re: [go-nuts] Importing non-module based code

2024-07-16 Thread robert engels
I think I figured it out. I need to create a tag I guess? Since @latest doesn’t pull head ? This seems to have changed, because I “think” this used to compile fine. > On Jul 16, 2024, at 8:40 AM, 'Robert Engels' via golang-nuts > wrote: > > Has it changed so that Go repo that imports a from

[go-nuts] Importing non-module based code

2024-07-16 Thread 'Robert Engels' via golang-nuts
Has it changed so that Go repo that imports a from another repo that doesn’t use modules no longer works? Maybe a recent change? I have a repo github.com/robaho/go-trader that imports githut.com/robaho/gocui (which is a fork