Re: [go-nuts] Shrinking pprof data for PGO through quantization.

2023-11-17 Thread 'Adam Azarchs' via golang-nuts
Thanks for the pointers! Looks like just the aggregation alone from your PR there cuts the size of the profile for the thing I was using it on to about a quarter the size, which is nice. Your CL there does in fact truncate the stacks to length 5, just kind of surprisingly does that while loop

[go-nuts] Re: Go-native abstract service interface design

2023-11-17 Thread 'Brian Candler' via golang-nuts
I think it depends on what your semantic contract is for this interface. If the caller starts a server with Run(ctx), is it implied that cancelling of ctx should stop the running server? If so, ISTM that there is no need for a separate Shutdown() method. (And there would be no need for App and