[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Tom Stellard
tstellar opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` @eclipseo Ok, I've update gotest as well. What do you think about removing the escape characters from the quotations? I couldn't get

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` I would expect that packages which redefine LDFLAGS are unaffected by the SetBuildFlagsBuildCheck change. What problems is it causing wi

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-25 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` @gota Do you have an example of a build where this fails? It was working for me when I tested it in mock. `` To reply, visit the link b

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-26 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` @gotmax23 OK, can you show me an example build where %{golang_filter_ldflags} expands to nothing? I would like to try to figure out what

[go-rpm-macros] PR #40: Try again to fix failures with https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-27 Thread Tom Stellard
tstellar opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Try again to fix failures with https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-re

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-27 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` @gotmax23 This pull request should fix it: https://pagure.io/go-rpm-macros/pull-request/40 `` To reply, visit the link below or just rep