gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of
random bytes` that you are following:
``
Is it possible for `$SOURCE_DATE_EPOCH` to be undefined? Should this have a
fallback or at least change to `${SOURCE_DATE_EPOCH-}` (in case a packager uses
`set -u` or such)?
``
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of
random bytes` that you are following:
``
I think in the Fedora case, SOURCE_DATE_EPOCH would always be defined. But
you're right, it's probably better to provide a fallback like for other
variables. I changed it to use `:
gotmax23 commented on the pull-request: `Add additional gobuildflags macros`
that you are following:
``
`-trimpath` apparently breaks debuginfo collection, so I'll drop that commit...
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/62
--
gotmax23 commented on the pull-request: `Add additional gobuildflags macros`
that you are following:
``
Okay, I did my normal build a hundred random Go packages that currently build
successfully according to Koschei routine in
https://copr.fedorainfracloud.org/coprs/gotmax23/go-rpm-macros-3.4.0
gotmax23 merged a pull-request against the project: `go-rpm-macros` that you
are following.
Merged pull-request:
``
Add additional gobuildflags macros
``
https://pagure.io/go-rpm-macros/pull-request/62
--
___
golang mailing list -- golang@lists.fedor
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of
random bytes` that you are following:
``
Cool. Thanks! Can you please rebase this now that other PR has been merged?
This flag has no moved to the `%gobuild_ldflags` definition.
``
To reply, visit the link below or just
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of
random bytes` that you are following:
``
Cool. Thanks! Can you please rebase this now that other PR has been merged?
This flag has no moved to the `%gobuild_ldflags` definition.
``
To reply, visit the link below or just
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of
random bytes` that you are following:
``
Rebased.
``
To reply, visit the link below or just reply to this email
https://pagure.io/go-rpm-macros/pull-request/63
--
___
golang mail
