Re: Enabling GOPROXY and GOSUMDB in Fedora

2023-12-20 Thread Ondrej Pohorelsky
I would personally go with the 2 and get closer to the upstream. I agree with the npm analogy that was made in the conversation. Furthermore, I don't think that most users, working on Go projects on Fedora, would even know that we provide different Go envars to the upstream ones. IMO, they would ch

Re: Enabling GOPROXY and GOSUMDB in Fedora

2023-12-20 Thread Maxwell G
On Wed Dec 20, 2023 at 12:14 +0100, Ondrej Pohorelsky wrote: > On Tue, Dec 19, 2023 at 11:11 PM Neal Gompa wrote: > > > On Tue, Dec 19, 2023 at 4:14 PM Brad Smith > > wrote: > > > > > > At a minimum, I recommend that the patch include the original values > > > for GOPROXY, GOSUMDB, and GOTOOLCHAI

Re: Enabling GOPROXY and GOSUMDB in Fedora

2023-12-20 Thread Brad Smith
Greetings - On Wed, Dec 20, 2023 at 7:35 AM Maxwell G wrote: > > Can someone clarify what they mean by this? The patch itself [1] makes > it pretty clear what the original values are. When I look at /usr/lib/golang/go.env I see: [bgsmith@pico newversionprep (main *%)]$ more /usr/lib/golan

Re: Enabling GOPROXY and GOSUMDB in Fedora

2023-12-20 Thread Maxwell G
On Wed Dec 20, 2023 at 07:57 -0800, Brad Smith wrote: > The go.env file does not, as far as I can tell, contain the original > values from upstream. Just the modified values. Unless I modified the > file and cannot recall doing so! My suggestion was to include the > original upstream settings as co