Re: golang 1.16 for epel7?

2022-01-21 Thread Jakub Čajka
Jan 21, 2022, 00:54 by d...@fnal.gov: > It turned out there were a couple of significant problems with that > first build, but they are fixed in golang-1.16.13-2 which should be > in epel-testing for epel7 by tomorrow. > https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-246382d5dc > It

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Tom Stellard
tstellar opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` This is hackish. Please also modify the gotest line ``` -%gotest() %{?gomodulesmode} go test %{gotestflags} -ldflags "${LDFLAGS:-} %{?cu

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` @eclipseo Ok, I've update gotest as well. What do you think about removing the escape characters from the quotations? I couldn't get

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` Thank you kindly! `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/38 _

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` We may have a problem on some packages. For some of them we redefine LDFLAGS: https://sourcegraph.com/search?q=context:global+r:src.fedora

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-21 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` I would expect that packages which redefine LDFLAGS are unaffected by the SetBuildFlagsBuildCheck change. What problems is it causing wi