On Wed Dec 20, 2023 at 07:57 -0800, Brad Smith wrote:
> The go.env file does not, as far as I can tell, contain the original
> values from upstream. Just the modified values. Unless I modified the
> file and cannot recall doing so! My suggestion was to include the
> original upstream settings as co
Greetings -
On Wed, Dec 20, 2023 at 7:35 AM Maxwell G wrote:
>
> Can someone clarify what they mean by this? The patch itself [1] makes
> it pretty clear what the original values are.
When I look at /usr/lib/golang/go.env I see:
[bgsmith@pico newversionprep (main *%)]$ more /usr/lib/golan
On Wed Dec 20, 2023 at 12:14 +0100, Ondrej Pohorelsky wrote:
> On Tue, Dec 19, 2023 at 11:11 PM Neal Gompa wrote:
>
> > On Tue, Dec 19, 2023 at 4:14 PM Brad Smith
> > wrote:
> > >
> > > At a minimum, I recommend that the patch include the original values
> > > for GOPROXY, GOSUMDB, and GOTOOLCHAI
I would personally go with the 2 and get closer to the upstream. I agree
with the npm analogy that was made in the conversation.
Furthermore, I don't think that most users, working on Go projects on
Fedora, would even know that we provide different Go envars
to the upstream ones. IMO, they would ch
On Tue, Dec 19, 2023 at 4:14 PM Brad Smith wrote:
>
> At a minimum, I recommend that the patch include the original values
> for GOPROXY, GOSUMDB, and GOTOOLCHAIN as comments. This makes it
> easier to change back to default values. At the moment, one has to
> visit the relevant web pages.
>
> I l
On Tue Dec 19, 2023 at 17:33 +0100, Alejandro Saez Morollon wrote:
> TL;DR: Remove a patch we ship in Go that disables GOPROXY and GOSUMDB and
> follow upstream defaults, or keep it?
I support keeping the Google Go module proxy disabled by default. Our
packages should not send telemetry data to Go
Hi everyone.
TL;DR: Remove a patch we ship in Go that disables GOPROXY and GOSUMDB and
follow upstream defaults, or keep it?
Recently, I had a short conversation in a public forum about two Go
features that we modified in Fedora. GOPROXY and GOSUMDB. As I prepare the
Fedora 40 and Go 1.22 proposa
