[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-03-06 Thread Zbigniew Jędrzejewski-Szmek
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` https://pagure.io/fedora-reproducible-builds/project/issue/15 for the follow-up. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-r

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-03-06 Thread Zbigniew Jędrzejewski-Szmek
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` I tested this with `osbuild-composer-102-1.fc41`. I still get a difference, but I think it must be caused by something else. Looking at the build log [1]: `+ go build -buildmode pi

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-03-01 Thread Maxwell G
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Thanks! `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63 -- ___ golang mail

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-03-01 Thread Maxwell G
gotmax23 merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` Use $SOURCE_DATE_EPOCH instead of random bytes `` https://pagure.io/go-rpm-macros/pull-request/63 -- ___ golang mailing list -- golang

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-03-01 Thread Alejandro Sáez Morollón
alexsaezm commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` +1 I like the idea. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63 -- __

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-29 Thread Zbigniew Jędrzejewski-Szmek
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Rebased. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63 -- ___ golang mail

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-29 Thread Maxwell G
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Cool. Thanks! Can you please rebase this now that other PR has been merged? This flag has no moved to the `%gobuild_ldflags` definition. `` To reply, visit the link below or just

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-29 Thread Maxwell G
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Cool. Thanks! Can you please rebase this now that other PR has been merged? This flag has no moved to the `%gobuild_ldflags` definition. `` To reply, visit the link below or just

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-29 Thread Zbigniew Jędrzejewski-Szmek
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` I think in the Fedora case, SOURCE_DATE_EPOCH would always be defined. But you're right, it's probably better to provide a fallback like for other variables. I changed it to use `:

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-29 Thread Maxwell G
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` Is it possible for `$SOURCE_DATE_EPOCH` to be undefined? Should this have a fallback or at least change to `${SOURCE_DATE_EPOCH-}` (in case a packager uses `set -u` or such)? ``

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-27 Thread Zbigniew Jędrzejewski-Szmek
zbyszek commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` If #62 is merged first, I'll rebase… `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63 -- ___

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-27 Thread Maxwell G
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` @alexsaezm, @jcajka, PTAL `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63 --

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-27 Thread Maxwell G
gotmax23 commented on the pull-request: `Use $SOURCE_DATE_EPOCH instead of random bytes` that you are following: `` This PR and https://pagure.io/go-rpm-macros/pull-request/62 conflict, so one of them will have to be rebased. `` To reply, visit the link below or just reply to this email https:/

[go-rpm-macros] PR #63: Use $SOURCE_DATE_EPOCH instead of random bytes

2024-02-27 Thread Zbigniew Jędrzejewski-Szmek
zbyszek opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Use $SOURCE_DATE_EPOCH instead of random bytes `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/63 -- __