[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-26 Thread Tom Stellard
tstellar commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` @gotmax23 OK, can you show me an example build where %{golang_filter_ldflags} expands to nothing? I would like to try to figure out what

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-26 Thread Maxwell G
gotmax23 commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` No builds are completely broken, but redefining LDFLAGS doesn't work. Instead of filtering out `-Wl,-z,relro` and keeping the rest of the

[go-rpm-macros] PR #38: Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck

2022-01-26 Thread Robert-André Mauchin
eclipseo commented on the pull-request: `Fix build failures due to https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck` that you are following: `` > > It looks like this change did not work as expected. > > `%{golang_filter_ldflags}` seems to expand to an empty string. > > Rpm `%()