Re: [GNUnet-developers] Coding style clang-format

Schanzenbach, Martin transcribed 6.4K bytes: > > > > On 15. Apr 2019, at 12:24, Christian Grothoff wrote: > > > > Signed PGP part > > Dear all, > > > > First of all, I like Martin's initiative as any attempt at trying to > > improve the situation is very welcome. Hartmut is of course right tha

Re: [GNUnet-developers] Coding style clang-format

> On 15. Apr 2019, at 12:24, Christian Grothoff wrote: > > Signed PGP part > Dear all, > > First of all, I like Martin's initiative as any attempt at trying to > improve the situation is very welcome. Hartmut is of course right that > it should be discussed, but I think committing the files fi

Re: [GNUnet-developers] Coding style clang-format

Dear all, First of all, I like Martin's initiative as any attempt at trying to improve the situation is very welcome. Hartmut is of course right that it should be discussed, but I think committing the files first so we have a good basis for discussion was also the right move. It's not like Martin

Re: [GNUnet-developers] The function of GNUNET_SCHEDULER_FdInfo->sock

I'm not sure what exactly you do not understand here, but the "fdset_test_native" call is simply checking if the given file descriptor/socket ("int" on UNIX) is in the "fd_set" represented by the first argument. Usually/often we use the variants with the FileHandle, but sometimes we don't have the

[GNUnet-developers] The function of GNUNET_SCHEDULER_FdInfo->sock

What is it used for? I did grep the code, but some things are unclear. Specifically, this field is sometimes used with the calls that look like: GNUNET_NETWORK_fdset_test_native (ws, pos->fdi->sock)) Does that imply that the sock field is

Re: [GNUnet-developers] Missing gnunet_reclaim_plugin.h

Sorry, fixed. > On 15. Apr 2019, at 11:00, LRN wrote: > > Signed PGP part > That file is mentioned in src/include/Makefile.am, but it's not in git. > > > signature.asc Description: Message signed with OpenPGP ___ GNUnet-developers mailing list GN

Re: [GNUnet-developers] Coding style clang-format

> On 15. Apr 2019, at 10:53, Hartmut Goebel > wrote: > > Am 15.04.19 um 10:02 schrieb Schanzenbach, Martin: >> FYI I added a clang-format at "contrib/conf/editors/clang-format". > > I'm curious about this, since the development guide says: "We follow the > GNU Coding Standards (see The GNU Co

Re: [GNUnet-developers] Coding style clang-format

Hi Hartmut, It's a bit disheartening to see an honest attempt to improve things being shot down like this. The clang-format style that Martin created tries to mirror what style the existing codebase already has or is supposed to have. If you want to make any tweaks on top of that, please contrib

[GNUnet-developers] Missing gnunet_reclaim_plugin.h

That file is mentioned in src/include/Makefile.am, but it's not in git. signature.asc Description: OpenPGP digital signature ___ GNUnet-developers mailing list GNUnet-developers@gnu.org https://lists.gnu.org/mailman/listinfo/gnunet-developers

Re: [GNUnet-developers] Coding style clang-format

Am 15.04.19 um 10:02 schrieb Schanzenbach, Martin: > FYI I added a clang-format at "contrib/conf/editors/clang-format". I'm curious about this, since the development guide says: "We follow the GNU Coding Standards (see The GNU Coding Standards

[GNUnet-developers] Coding style clang-format

Hi, FYI I added a clang-format at "contrib/conf/editors/clang-format". Clang-format is usable with most editors (vim, emacs, vscode) with respective plugins. This way, we can have a unified coding style. Clang-format has a nice documentation and allows fine-grained setting which are also human r