Re: [GNC] Notes (few other) fields should be editable even after posting invoice

2019-10-18 Thread Amish
Hi, Thank you very much for merging the PR. On a side note, any idea why the following is being done? Source: gnucash/gnome/dialog-invoice.c 1921: gtk_widget_set_sensitive (iw->id_entry, FALSE); /* XXX: why set FALSE and then TRUE? */ 1922: gtk_widget_set_sensitive (iw->id_entry, TRUE); It

Re: [GNC] Notes (few other) fields should be editable even after posting invoice

2019-10-17 Thread Geert Janssens
Hi, I agree unconditionally on the notes field. And I can see how being able to pull up job or customer/vendor details directly from the invoice window could be a big time saver. So I have merged your PR to revert the read-only status of these three fields as I find the old behavior's use case

[GNC] Notes (few other) fields should be editable even after posting invoice

2019-10-14 Thread Amish
Hello, There was this fix implemented in Gnucash which inadvertently created issue for me. This was the bug report which was marked RESOLVED FIXED. https://bugs.gnucash.org/show_bug.cgi?id=797168 But this fix created issue with respect to my GST filing and tracking. So I counter opened a bug