Re: [GNC-dev] Python code formatter - black

2020-07-11 Thread c . holtermann
Ok, I'll have a look at different ones. Try them on my commits and on the way maybe we'll agree on one (with certain settings) for the whole python codebase. Black is basically not configurable. Here's one article comparing black, yapf, autopep8 but not pylint: https://blog.frank-mich.com/python-c

Re: [GNC-dev] Python code formatter - black

2020-07-11 Thread John Ralls
Not much of a comparison. I thought it interesting that the author complained of black reducing vertical space and I complained of it increasing it. I suppose it has a toggle: If a statement will fit on a line put it on a line otherwise add parentheses and break on every comma. https://books.ag

[GNC-dev] Compiling on maint

2020-07-11 Thread jean
Devs, I'm running into this problem running cmake on the mac: cmake -G Xcode -D CMAKE_INSTALL_PREFIX=$PREFIX -D GTEST_ROOT=$SRCROOT/googletest/googletest -D GMOCK_ROOT=$SRCROOT/googletest/googlemock $SRCROOT/gnucash-git -- Checking for GTEST CMake Error at common/cmake_modules/GncAddTest.cma

Re: [GNC-dev] Compiling on maint

2020-07-11 Thread Chris Graves
Jean, I don’t think you need to specify GMOCK_ROOT any longer and I believe GTEST_ROOT should point to the top level googletest dir. So maybe give this a try: cmake -G Xcode -D CMAKE_INSTALL_PREFIX=$PREFIX -D GTEST_ROOT=$SRCROOT/googletest $SRCROOT/gnucash-git Chris > On Jul 11, 2020, at 1

Re: [GNC-dev] Compiling on maint

2020-07-11 Thread jean
Thanks Chris, I believe that did the trick. What about on Master? Jean On 7/11/20 11:25 AM, Chris Graves wrote: Jean, I don’t think you need to specify GMOCK_ROOT any longer and I believe GTEST_ROOT should point to the top level googletest dir. So maybe give this a try: cmake -G Xcode -D CM

Re: [GNC-dev] Compiling on maint

2020-07-11 Thread Chris Graves
Yes, I believe so. > On Jul 11, 2020, at 11:33 AM, jean wrote: > > Thanks Chris, I believe that did the trick. > What about on Master? > Jean > > On 7/11/20 11:25 AM, Chris Graves wrote: >> Jean, >> I don’t think you need to specify GMOCK_ROOT any longer and I believe >> GTEST_ROOT should poin

Re: [GNC-dev] Compiling on maint

2020-07-11 Thread jean
Meaning same right? OK I'll give that a shot! Thanks a bunch! J. On 7/11/20 11:35 AM, Chris Graves wrote: Yes, I believe so. On Jul 11, 2020, at 11:33 AM, jean wrote: Thanks Chris, I believe that did the trick. What about on Master? Jean On 7/11/20 11:25 AM, Chris Graves wrote: Jean, I don