Re: [GNC-dev] gnc:debug changes

2020-03-07 Thread Christopher Lam
On Sat, 7 Mar 2020 at 06:18, Mike Alexander wrote: > I understand. Avoiding the call to strify is a good idea and I don't > intend to change that. I was simply pointing out that evaluating the args > to gnc:debug may also take some time. In the case you mention presumably > pricelist already exis

Re: [GNC-dev] Build on MacOS

2020-03-07 Thread John Ralls
> On Mar 6, 2020, at 9:27 PM, jean laroche wrote: > > Thanks John, > > Tonight I was able to successfully run jhbuild build, then to build and run > gnucash on my mac at home. > Doing so required some manual fixes which I'm listing below. If it's not > possible to patch them, at least they s

Re: [GNC-dev] gnc:debug changes

2020-03-07 Thread Mike Alexander
On 7 Mar 2020, at 5:22, Christopher Lam wrote: Ok I think your changes are fine. I don't understand qof_log_check I'd hope it's not slow. I just pushed the change. qof_log_check is called a *lot* and I don't think it's a problem. It does a couple of hash table lookups and a couple of string

Re: [GNC-dev] Build on MacOS

2020-03-07 Thread jean laroche
Thanks John, I'm going to retry from a clean slate. A million thanks for all you've done to make this a lot easier for noobs like me. Now that I"m able to build, I wonder where/how I can contribute. I know of things that I would love to change to make them more streamlined for me, but that's ju