Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

2020-01-03 Thread Phil Longstaff
I will continue this discussion here because I can no longer comment on the change on github. No, I understand you aren't trying to be difficult. I think when I made the original change, my books were set with a certain sign-reversal setting and I didn't test with other settings. My problem now i

Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

2020-01-03 Thread Christopher Lam
Thank you Phil. Github isn't logged anywhere apart from web interface, hence not the best for discussion. The only hiccup I really want to elucidate is whether equity being part of Transfer line is needed at all. So please let me know whether it should be part of the equation at all. My suggesti

Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

2020-01-03 Thread Phil Longstaff
I can't think of any reason that equity needs to be included. On Fri, Jan 3, 2020 at 9:54 AM Christopher Lam wrote: > Thank you Phil. Github isn't logged anywhere apart from web interface, > hence not the best for discussion. > > The only hiccup I really want to elucidate is whether equity bein

Re: [GNC-dev] Enabling github branch protection rules? Re: [Gnucash/gnucash] po/de.po: fix translation bug (#627)

2020-01-03 Thread Christian Stimming
John, thanks a lot for testing. Well, that's unfortunate. However, maybe some of the other rules would help us to avoid this better? https://github.com/Gnucash/gnucash/settings/branch_protection_rules/new How about activating "Require pull request reviews before merging" with maybe "2"? Again,

Re: [GNC-dev] Enabling github branch protection rules? Re: [Gnucash/gnucash] po/de.po: fix translation bug (#627)

2020-01-03 Thread John Ralls
Christian, Well, it does disable the merge button. "applies to administrators" has to be checked too for it to apply to you, me, and Geert. Unfortunately it also applies to pushes from code: Counting objects: 16, done. Delta compression using up to 16 threads. Compressing objects: 100% (16/16),

Re: [GNC-dev] [Gnucash/gnucash] [gnc-budget-view.c] totals - 5 fundamental types (775200e)

2020-01-03 Thread Christopher Lam
Thanks for clarifying that equity was probably a coding error. I also managed to find the original commit message 190665ac which confirms. I'll try to redo, and ensure that the summary lines are as follows... I think they should be insensitive to the sign-reversal preference. "2) GncBudgetView cha