Re: Beyond 2.8 - some design thoughts

2017-12-29 Thread Alen Siljak
I'd like to add that, to me, the difference between stable and unstable version is obvious enough if I see v2.8.0-alpha1, 2.8.0-alpha2, 2.8.0-beta1, 2.8.0-rc1, and then 2.8.0. I see no need for separate version numbers. However, I don't feel strongly about the version numbers as lon

Pull Requests

2017-12-29 Thread Robert Fewell
I had some time to go through the pull requests I had created and extract the fixes that I think should be included before the code freeze and created PR 251. Others can be included if deemed appropriate and good enough otherwise I will work on them in the new year. Regards, Bob _

Re: gnucash unstable: Multiple changes pushed

2017-12-29 Thread Geert Janssens
Op woensdag 27 december 2017 00:37:19 CET schreef John Ralls: > commit 91727525b9cd3c12f4fa25268131b0161c6fc79e > Author: John Ralls > Date: Tue Dec 26 13:01:50 2017 -0800 > > Enforce -Werror on C++ files and fix resulting errors. > > diff --git a/gnucash/import-export/csv-imp/assistant

Re: Beyond 2.8 - some design thoughts

2017-12-29 Thread Geert Janssens
Op vrijdag 29 december 2017 10:11:08 CET schreef Alen Siljak: > I'd like to add that, to me, the difference between stable and unstable > version is obvious enough if I see v2.8.0-alpha1, 2.8.0-alpha2, > 2.8.0-beta1, 2.8.0-rc1, and then 2.8.0. I see no need for separate version > numbers. That's a

Re: gnucash unstable: Multiple changes pushed

2017-12-29 Thread John Ralls
> On Dec 29, 2017, at 7:41 AM, Geert Janssens > wrote: > > Op woensdag 27 december 2017 00:37:19 CET schreef John Ralls: >> commit 91727525b9cd3c12f4fa25268131b0161c6fc79e >> Author: John Ralls >> Date: Tue Dec 26 13:01:50 2017 -0800 >> >>Enforce -Werror on C++ files and fix resulting

Re: gnucash unstable: Multiple changes pushed

2017-12-29 Thread Aaron Laws
On Fri, Dec 29, 2017 at 11:22 AM, John Ralls wrote: > > > I think that we should remove -Wno-unused from CXXFLAGS in general and > only use it where needed on external sources. GnuCash C++ code is all new > and it should all compile clean. For that code the more warnings the > better: It gets the

Re: gnucash unstable: Multiple changes pushed

2017-12-29 Thread Geert Janssens
Op vrijdag 29 december 2017 17:22:29 CET schreef John Ralls: > > On Dec 29, 2017, at 7:41 AM, Geert Janssens > > wrote:> > > Op woensdag 27 december 2017 00:37:19 CET schreef John Ralls: > >> commit 91727525b9cd3c12f4fa25268131b0161c6fc79e > >> Author: John Ralls > >> Date: Tue Dec 26 13:01:50

Re: gnucash unstable: Multiple changes pushed

2017-12-29 Thread Aaron Laws
> > Ok, that's a good motivation. Just to be clear for me, having a function > static is different from having a static variable, right ? As I understand > it > the latter is bad for thread safety, the former only ensures its local > scope. There two "static"s to keep in mind: static storage dura

Re: gnucash unstable: Multiple changes pushed

2017-12-29 Thread Aaron Laws
On Fri, Dec 29, 2017 at 12:06 PM, Aaron Laws wrote: > Ok, that's a good motivation. Just to be clear for me, having a function >> static is different from having a static variable, right ? As I >> understand it >> the latter is bad for thread safety, the former only ensures its local >> scope. >

Re: gnucash unstable: Multiple changes pushed

2017-12-29 Thread John Ralls
> On Dec 29, 2017, at 8:55 AM, Geert Janssens > wrote: > > Op vrijdag 29 december 2017 17:22:29 CET schreef John Ralls: >>> On Dec 29, 2017, at 7:41 AM, Geert Janssens >>> wrote:> >>> Op woensdag 27 december 2017 00:37:19 CET schreef John Ralls: commit 91727525b9cd3c12f4fa25268131b0161c

Re: Beyond 2.8 - some design thoughts

2017-12-29 Thread John Ralls
> On Dec 29, 2017, at 8:20 AM, Geert Janssens > wrote: > > Op vrijdag 29 december 2017 10:11:08 CET schreef Alen Siljak: >> I'd like to add that, to me, the difference between stable and unstable >> version is obvious enough if I see v2.8.0-alpha1, 2.8.0-alpha2, >> 2.8.0-beta1, 2.8.0-rc1, and

Re: Beyond 2.8 - some design thoughts

2017-12-29 Thread Geert Janssens
Op vrijdag 29 december 2017 18:23:57 CET schreef John Ralls: > > On Dec 29, 2017, at 8:20 AM, Geert Janssens > > wrote:> > > Op vrijdag 29 december 2017 10:11:08 CET schreef Alen Siljak: > >> I'd like to add that, to me, the difference between stable and unstable > >> version is obvious enough if

Re: Beyond 2.8 - some design thoughts

2017-12-29 Thread Sumit Bhardwaj
Geert, How would this impact the branching? Would we still have master, unstable, and maint? And, how would those correspond to the release versions? Thanks, Sumit On Fri, Dec 29, 2017 at 10:03 AM, Geert Janssens wrote: > Op vrijdag 29 december 2017 18:23:57 CET schreef John Ralls: > > > On De

Re: Beyond 2.8 - some design thoughts

2017-12-29 Thread Geert Janssens
Op vrijdag 29 december 2017 19:12:59 CET schreef Sumit Bhardwaj: > Geert, > > How would this impact the branching? Would we still have master, unstable, > and maint? And, how would those correspond to the release versions? > The branches would remain as they are now. All backwards incompatible o