Deleting an account referenced by other objects

2010-03-10 Thread Phil Longstaff
Bug 140400 (https://bugzilla.gnome.org/show_bug.cgi?id=140400) says that you can delete an account even though business objects still refer to that account. I want to tackle this bug. In general, no object should be deleted if there are other objects that refer to it. What do we want gnucash to

Re: Stabilizing 2.4.0

2010-03-10 Thread Phil Longstaff
On Sun, 2010-03-07 at 22:31 +0100, Christian Stimming wrote: > Am Sonntag, 7. März 2010 schrieb John Ralls: > > > http://wiki.gnucash.org/wiki/Release_Schedule#Feature_Checklist_for_2.4.0 > > > > I've added a couple of OSX status items for things I know about. > > > > I also fixed up the releases

Re: Deleting an account referenced by other objects

2010-03-10 Thread Geert Janssens
On Wednesday 10 March 2010, Phil Longstaff wrote: > Bug 140400 (https://bugzilla.gnome.org/show_bug.cgi?id=140400) says that > you can delete an account even though business objects still refer to > that account. I want to tackle this bug. > Great ! I think it's the oldest critical bug still open

Re: Windows XP, gnucash build problems

2010-03-10 Thread Christian Stimming
Hi Geert, Zitat von Geert Janssens : I'm trying to setup a build environment for GnuCash on WinXP, 32bit to try and help to fix some windows specific issues. ... The build stops because of this error make[3]: Entering directory `/C/GCDevel/tmp/OpenSP-1.5.2/sx' g++ -DHAVE_CONFIG_H -I. -I.. -I.

Re: Deleting an account referenced by other objects

2010-03-10 Thread Geert Janssens
On Wednesday 10 March 2010, Phil Longstaff wrote: > > > If I try to delete an account that still has splits, I am given a > > > dialog box so that you can move the splits to another account. Suppose > > > I try to delete a tax table that still has vendors or billterms that > > > refer to it? Get

Re: Deleting an account referenced by other objects

2010-03-10 Thread Phil Longstaff
On Wed, 2010-03-10 at 12:16 +0100, Geert Janssens wrote: > On Wednesday 10 March 2010, Phil Longstaff wrote: > > Bug 140400 (https://bugzilla.gnome.org/show_bug.cgi?id=140400) says that > > you can delete an account even though business objects still refer to > > that account. I want to tackle thi

Regression fix: patch for colored tabs segfault in trunk

2010-03-10 Thread Tom Van Braeckel
Hi, Commit 18881 causes a segfault at startup for users that have renamed their "Accounts" tab, the attached patch fixes it. This bug had been patched before, but then the code was reverted and later brought back, without reapplying the patch. Best regards, Tom. Index: src/gnome-utils/gnc-main-

Re: Regression fix: patch for colored tabs segfault in trunk

2010-03-10 Thread Geert Janssens
On Wednesday 10 March 2010, Tom Van Braeckel wrote: > Hi, > > Commit 18881 causes a segfault at startup for users that have renamed their > "Accounts" tab, the attached patch fixes it. > > This bug had been patched before, but then the code was reverted and later > brought back, without reapplyin

Re: r18878 - gnucash/trunk/src/business/business-ledger - Bug#325436 creating income account for invoice doesn't restrict account type

2010-03-10 Thread Derek Atkins
Geert Janssens writes: > On Tuesday 9 March 2010, Derek Atkins wrote: >> Geert Janssens writes: >> > +account_types = g_list_prepend (account_types, >> > (gpointer)ACCT_TYPE_CREDIT); +account_types = g_list_prepend >> > (account_types, (gpointer)ACCT_TYPE_ASSET); +account

Re: Regression fix: patch for colored tabs segfault in trunk

2010-03-10 Thread Tom Van Braeckel
On Wed, Mar 10, 2010 at 2:22 PM, Geert Janssens wrote: > On Wednesday 10 March 2010, Tom Van Braeckel wrote: > > Hi, > > > > Commit 18881 causes a segfault at startup for users that have renamed > their > > "Accounts" tab, the attached patch fixes it. > > > > This bug had been patched before, but

Re: Deleting an account referenced by other objects

2010-03-10 Thread Derek Atkins
Geert Janssens writes: >> Yes, making it generic enough is the question. I'll start with a list >> for now. At least that's better than a "sorry, I can't delete this >> object because something else refers to it and you need to figure out >> what that other object is" dialog. >> > Agreed. > >>

Re: Deleting an account referenced by other objects

2010-03-10 Thread John Ralls
On Mar 10, 2010, at 6:56 AM, Derek Atkins wrote: > And that's exactly why I didn't tackle the problem. I didn't want to > make an Account knowledgeable about an Invoice or GncEntry. So I > basically left it with a "just don't do that". Which is where we are > now. > > Fixing this. Would

Re: r18883 - gnucash/trunk/src/gnome-utils - Bug #525821 new or edited account names should be checked for reserved chars like ":"

2010-03-10 Thread Derek Atkins
Geert Janssens writes: > Author: gjanssens > Date: 2010-03-09 17:50:08 -0500 (Tue, 09 Mar 2010) > New Revision: 18883 > Trac: http://svn.gnucash.org/trac/changeset/18883 > > Modified: >gnucash/trunk/src/gnome-utils/dialog-account.c > Log: > Bug #525821 new or edited account names should be ch

compile error r18884

2010-03-10 Thread Herbert Thoma
Hi! With latest trunk I get a complie error: cc1: warnings being treated as errors gnc-main-window.c: In function ‘main_window_update_page_name’: gnc-main-window.c:1928: error: implicit declaration of function ‘g_strstr’ gnc-main-window.c:1928: error: comparison between pointer and integer make[5

Re: Deleting an account referenced by other objects

2010-03-10 Thread Derek Atkins
John Ralls writes: > On Mar 10, 2010, at 6:56 AM, Derek Atkins wrote: > >> And that's exactly why I didn't tackle the problem. I didn't want to >> make an Account knowledgeable about an Invoice or GncEntry. So I >> basically left it with a "just don't do that". Which is where we are >> now. >>

Re: compile error r18884

2010-03-10 Thread Derek Atkins
Herbert, Herbert Thoma writes: > Hi! > > With latest trunk I get a complie error: > > cc1: warnings being treated as errors > gnc-main-window.c: In function ‘main_window_update_page_name’: > gnc-main-window.c:1928: error: implicit declaration of function ‘g_strstr’ > gnc-main-window.c:1928: erro

Re: Deleting an account referenced by other objects

2010-03-10 Thread Phil Longstaff
On Wed, 2010-03-10 at 09:56 -0500, Derek Atkins wrote: > Geert Janssens writes: > > >> Yes, making it generic enough is the question. I'll start with a list > >> for now. At least that's better than a "sorry, I can't delete this > >> object because something else refers to it and you need to fi

Re: compile error r18884

2010-03-10 Thread Geert Janssens
On Wednesday 10 March 2010, Herbert Thoma wrote: > Hi! > > With latest trunk I get a complie error: > > cc1: warnings being treated as errors > gnc-main-window.c: In function ‘main_window_update_page_name’: > gnc-main-window.c:1928: error: implicit declaration of function ‘g_strstr’ > gnc-main-wi

Re: compile error r18884

2010-03-10 Thread Geert Janssens
On Wednesday 10 March 2010, Derek Atkins wrote: > Herbert, > > Herbert Thoma writes: > > Hi! > > > > With latest trunk I get a complie error: > > > > cc1: warnings being treated as errors > > gnc-main-window.c: In function ‘main_window_update_page_name’: > > gnc-main-window.c:1928: error: implici

compile error r18884

2010-03-10 Thread Robert Fewell
Hi, Looking r18884 and r18659 I think there is an r missing in g_strstr, should be g_strrstr Regards, Bob ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: r18883 - gnucash/trunk/src/gnome-utils - Bug #525821 new or edited account names should be checked for reserved chars like ":"

2010-03-10 Thread Geert Janssens
On Wednesday 10 March 2010, Derek Atkins wrote: > Geert Janssens writes: > > Author: gjanssens > > Date: 2010-03-09 17:50:08 -0500 (Tue, 09 Mar 2010) > > New Revision: 18883 > > Trac: http://svn.gnucash.org/trac/changeset/18883 > > > > Modified: > >gnucash/trunk/src/gnome-utils/dialog-account.

Re: compile error r18884

2010-03-10 Thread Geert Janssens
On Wednesday 10 March 2010, Robert Fewell wrote: > Hi, > > Looking r18884 and r18659 I think there is an r missing in g_strstr, should > be g_strrstr > Yes, exactly. That was my mistake. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org ht

Unpredictable make -- possibly related to intl-scm/guile-strings.c

2010-03-10 Thread Jeff Kletsky
I've been running in circles for the last several days with a problem that manifests itself when, from what I can tell, the code in engine.i tries to create Guile variables using the SET_ENUM construct. The console, in my case, reports Backtrace: In current input: 1: 0* (set! OPTION-SECTION-AC

Re: Unpredictable make -- possibly related to intl-scm/guile-strings.c

2010-03-10 Thread Jeff Kletsky
This pretty much looks like a build system problem: # Clean everything out # the build directory rm -rf gnucash-build/ mkdir gnucash-build # and the working repository cd gnucash-devel/ rm -rf * rm .gitignore # Get the "good" version, totally fresh git checkout edd8b26 git reset --hard # Bu