Re: Source directory restructuring complete

On woensdag 16 augustus 2017 20:50:59 CEST Eric Theise wrote: > On Wed, Aug 16, 2017 at 12:42 AM, Geert Janssens > wrote: > > > I now get as far as the "Making check in po" stage. > > > > > > ... > > > > > > Making check in po > > > rm -f missing notexist > > > srcdir=../../po /usr/bin/intltool-

Re: Source directory restructuring complete

On zondag 20 augustus 2017 14:28:06 CEST Robert Fewell wrote: > OK found this one, pre-restructure there was a gncmod-business. that > loaded the "gnucash/gnome-search" module but that has been removed so there > is no search available at the moment. To fix, it can be added to the list > of mod

Re: Source directory restructuring complete

OK found this one, pre-restructure there was a gncmod-business. that loaded the "gnucash/gnome-search" module but that has been removed so there is no search available at the moment. To fix, it can be added to the list of modules in gnucash-bin.c or should it go some where else ? Bob On 17 Au

Re: Source directory restructuring complete

On Fri, Aug 18, 2017 at 12:30 AM, Geert Janssens wrote: > On vrijdag 18 augustus 2017 07:07:02 CEST Sumit Bhardwaj wrote: > > Hi Geert, > > > > Coming back to this thread, I found some time today to see if I can build > > using autotools. After pulling the latest master, "make" and "make check" >

Re: Source directory restructuring complete

On vrijdag 18 augustus 2017 07:07:02 CEST Sumit Bhardwaj wrote: > Hi Geert, > > Coming back to this thread, I found some time today to see if I can build > using autotools. After pulling the latest master, "make" and "make check" > both worked. So, I am good building with autotools. > Good. Just

Re: Source directory restructuring

On donderdag 17 augustus 2017 23:59:56 CEST Alex Aycinena wrote: > I can also verify, from an earlier build, that test-import-pending-matches > is run on my system with autotools. It didn't run after the latest git pull > because of the test-backend-dbi failure in autotools as well. > > That's a n

Re: Source directory restructuring

> On Aug 17, 2017, at 11:59 PM, Alex Aycinena wrote: > >> -- Forwarded message -- >> From: Geert Janssens >> To: gnucash-devel >> Cc: >> Bcc: >> Date: Wed, 16 Aug 2017 12:44:52 +0200 >> Subject: Re: Source directory restructur

Re: Source directory restructuring complete

Hi Geert, Coming back to this thread, I found some time today to see if I can build using autotools. After pulling the latest master, "make" and "make check" both worked. So, I am good building with autotools. For now, I will try to work on CSV importer if and when I find time - it's going to be

Re: Source directory restructuring

> -- Forwarded message -- > From: Geert Janssens > To: gnucash-devel > Cc: > Bcc: > Date: Wed, 16 Aug 2017 12:44:52 +0200 > Subject: Re: Source directory restructuring > On maandag 14 augustus 2017 02:59:58 CEST Alex Aycinena wrote: > > I did a

Re: Source directory restructuring complete

Hi Bob, I've been seeing this for quite some time now. Don't know where exactly it started. But it's definitely not local to you. Geert On donderdag 17 augustus 2017 13:12:34 CEST Robert Fewell wrote: > Just built with the new structure and I see the following in the trace > file... > > * 12:0

Re: Source directory restructuring complete

Just built with the new structure and I see the following in the trace file... * 12:03:29 WARN Could not locate module gnucash/plugins/bi_import interface v.0 * 12:03:29 CRIT gnc_search_core_register_type: assertion 'typeTable' failed The first one was easy, I had a config.user file with the

Re: Source directory restructuring complete

> On Aug 17, 2017, at 9:37 AM, Geert Janssens > wrote: > > On woensdag 16 augustus 2017 23:20:00 CEST John Ralls wrote: >>> On Aug 16, 2017, at 11:12 PM, Aaron Laws wrote: >>> >>> On Wed, Aug 16, 2017 at 4:52 PM, John Ralls >> >> >>> wrote: Later, w

Re: Source directory restructuring complete

On donderdag 17 augustus 2017 10:02:02 CEST John Ralls wrote: > Nope, the problem is at > https://github.com/Gnucash/gnucash/blob/master/libgnucash/engine/qof-backen > d.cpp#L141: > nd.cpp#L141:> /* Darwin modules can hav

Re: Source directory restructuring complete

On woensdag 16 augustus 2017 23:20:00 CEST John Ralls wrote: > > On Aug 16, 2017, at 11:12 PM, Aaron Laws wrote: > > > > On Wed, Aug 16, 2017 at 4:52 PM, John Ralls > >> > > wrote: > >> Later, when trying to run GnuCash I found that > >> libgncmod-backend-d

Re: Source directory restructuring complete

> On Aug 16, 2017, at 11:12 PM, Aaron Laws wrote: > > On Wed, Aug 16, 2017 at 4:52 PM, John Ralls > > wrote: > >> Later, when trying to run GnuCash I found that libgncmod-backend-dbi.dylib >> didn't load because the directory being passed in was "dbi" inst

Re: Source directory restructuring complete

On Wed, Aug 16, 2017 at 4:52 PM, John Ralls wrote: > Later, when trying to run GnuCash I found that libgncmod-backend-dbi.dylib > didn't load because the directory being passed in was "dbi" instead of > "gnucash". > --- a/libgnucash/engine/gnc-engine.c > +++ b/libgnucash/engine/gnc-engine.c > @@

Re: Source directory restructuring complete

> On Aug 16, 2017, at 12:21 PM, John Ralls > wrote: > >> >> On Aug 14, 2017, at 6:57 PM, Geert Janssens >> wrote: >> >> Hi, >> >> I have just pushed my directory restructuring branch to master as I >> announced >> last week. >> >> IMPORTANT: You should wipe out your existing build/insta

Re: Source directory restructuring complete

On Wed, Aug 16, 2017 at 12:42 AM, Geert Janssens wrote: > > I now get as far as the "Making check in po" stage. > > > > ... > > > > Making check in po > > rm -f missing notexist > > srcdir=../../po /usr/bin/intltool-update -m > > All the missing file errors are the result of your build directory

Re: Source directory restructuring

On maandag 14 augustus 2017 02:59:58 CEST Alex Aycinena wrote: > I did a test by test comparison using Testing/Temporary/LastTest.log also > and I find there are three tests in autotools that are missing in cmake: > > - src/engine/test/test-import-map > - src/engine/test/test-engine > - src/app

Re: Source directory restructuring complete

> On Aug 14, 2017, at 6:57 PM, Geert Janssens > wrote: > > Hi, > > I have just pushed my directory restructuring branch to master as I announced > last week. > > IMPORTANT: You should wipe out your existing build/install directory after > pulling this new master. And if you are building in

Re: Source directory restructuring complete

On woensdag 16 augustus 2017 04:37:30 CEST Eric Theise wrote: > Thanks Geert, that worked. I live in San Francisco so the LA time zone test > shouldn't normally pose a problem for me. > Ok. > I do wonder if there's something stronger than "make --no-print-directory > check" that suppresses everyt

Re: Source directory restructuring complete

Thanks Geert, that worked. I live in San Francisco so the LA time zone test shouldn't normally pose a problem for me. I do wonder if there's something stronger than "make --no-print-directory check" that suppresses everything but the Testsuite summaries? I now get as far as the "Making check in p

Re: Source directory restructuring complete

On dinsdag 15 augustus 2017 21:13:00 CEST Eric Theise wrote: > Contents of libgnucash/engine/test/test-qof.log: > > /qof/qofbook/readonly: OK > /qof/qofbook/validate counter: OK > /qof/qofbook/get string option: OK > /qof/qofbook/set string option: OK > /qof/qofbook/session not saved: OK > /qof/qo

Re: Source directory restructuring complete (Geert Janssens)

On dinsdag 15 augustus 2017 22:51:36 CEST Alex Aycinena wrote: > On Tue, Aug 15, 2017 at 1:23 PM, Alex Aycinena > > wrote: > > Hi Geert, > > > > I did a new clone with a parallel build directory in three Fedora's and > > had mixed results: > > > > F24 - with cmake/ninja: clean ninja-build, ninj

Re: Source directory restructuring complete (Geert Janssens)

On Tue, Aug 15, 2017 at 1:23 PM, Alex Aycinena wrote: > > > Hi Geert, > > I did a new clone with a parallel build directory in three Fedora's and > had mixed results: > > F24 - with cmake/ninja: clean ninja-build, ninja-build check, ninja-build > install and gnucash started OK and ran. > > F26 VM

Re: Source directory restructuring complete (Geert Janssens)

> > > -- Forwarded message -- > From: Geert Janssens > To: gnucash-devel@gnucash.org > Cc: > Bcc: > Date: Tue, 15 Aug 2017 16:54:23 +0200 > Subject: Re: Source directory restructuring complete > Hmm, > > And I meant to add, can you post t

Re: Source directory restructuring complete

Contents of libgnucash/engine/test/test-qof.log: /qof/qofbook/readonly: OK /qof/qofbook/validate counter: OK /qof/qofbook/get string option: OK /qof/qofbook/set string option: OK /qof/qofbook/session not saved: OK /qof/qofbook/session mark saved: OK /qof/qofbook/get counter: (/home/erictheise/Repo

Re: Source directory restructuring complete

Hi Geert, Here's some output. I'm running autogen.sh + make on an Ubuntu 16.04 VM. This is actually the first time I've been able to get gnucash to install so I consider it a big step forward. Eric ... PASS: test-commodities ../../../../test-driver: line 107: 11950 Aborted (core

Re: Source directory restructuring complete

Hmm, And I meant to add, can you post the contents of the test logs for the failing tests ? You will find them in ../build_gnucash/libgnucash/engine/test/ The logs are named after the tests so you'll be looking for test-test-extras.log test-account.log test-split.log Geert On dinsdag 15 august

Re: Source directory restructuring complete

Hi Sumit, Thanks for running the tests and reporting your issues. These are not known problems. I have run both cmake and autotools builds before submitting my work and for both build systems I had all the tests succeeding. The autotools build also completes fine on travis. So there is somethin

Re: Source directory restructuring complete

Hi Geert, Pulled master and tried to build using autotoosls. As per your suggestion, I built in ../build_gnucash which is parallel to the top-level gnucash directory. make succeeded. make install succeeded as well. make check failed with 3 tests - error message below. Is this a known problem? I

Source directory restructuring complete

Hi, I have just pushed my directory restructuring branch to master as I announced last week. IMPORTANT: You should wipe out your existing build/install directory after pulling this new master. And if you are building in the source tree (which we don't advise) instead of having a separate build

Re: Source directory restructuring

On Sun, Aug 13, 2017 at 3:52 AM, Geert Janssens wrote: > On zondag 13 augustus 2017 01:34:34 CEST Alex Aycinena wrote: > > John, > > > > I did a test-by-test comparison and found the following: > > > > in cmake but not exactly the same in autotools: > > > > Test #49: scm-test-account > > Test #

Re: Source directory restructuring

On zondag 13 augustus 2017 12:52:34 CEST Geert Janssens wrote: > On zondag 13 augustus 2017 01:34:34 CEST Alex Aycinena wrote: > > John, > > > > I did a test-by-test comparison and found the following: > > > > in cmake but not exactly the same in autotools: > > > > Test #49: scm-test-account >

Re: Source directory restructuring

On zondag 13 augustus 2017 01:34:34 CEST Alex Aycinena wrote: > John, > > I did a test-by-test comparison and found the following: > > in cmake but not exactly the same in autotools: > > Test #49: scm-test-account > Test #50: scm-test-create-account > Test #51: scm-test-test-extra > Test #52

Re: Source directory restructuring

ont.ca.us>> >>>>> To: Sumit Bhardwaj mailto:bhardw...@gmail.com>> >>>>> Cc: gnucash-devel >>>> <mailto:gnucash-devel@gnucash.org>> >>>>> Bcc: >>>>> Date: Tue, 8 Aug 2017 20:01:44 +0300 >>>>> S

Re: Source directory restructuring

t;> From: John Ralls >> >> To: Sumit Bhardwaj >> >> Cc: gnucash-devel >> >> Bcc: >> >> Date: Tue, 8 Aug 2017 20:01:44 +0300 >> >> Subject: Re: Source directory restructuring >> >> >> >>> On Aug 8, 2017, at

Re: Source directory restructuring

On zaterdag 12 augustus 2017 07:38:31 CEST John Ralls wrote: > > On Aug 12, 2017, at 6:22 AM, Frank H. Ellenberger > > wrote: > > > > Hi, > > > > Am 08.08.2017 um 09:29 schrieb Geert Janssens: > >> On maandag 7 augustus 2017 21:27:18 CEST John Ralls wrote: > >>> These are to be top-level directo

Re: Source directory restructuring

> On Aug 12, 2017, at 6:22 AM, Frank H. Ellenberger > wrote: > > Hi, > > Am 08.08.2017 um 09:29 schrieb Geert Janssens: >> On maandag 7 augustus 2017 21:27:18 CEST John Ralls wrote: >>> These are to be top-level directories, so the current src goes away, right? >>> The rest assumes that to be

Re: Source directory restructuring

Hi, Am 08.08.2017 um 09:29 schrieb Geert Janssens: > On maandag 7 augustus 2017 21:27:18 CEST John Ralls wrote: >> These are to be top-level directories, so the current src goes away, right? >> The rest assumes that to be the case. >> > Yes, I would drop src. > Ahem, if I understand them right,

Re: cmake failure (was:Re: Source directory restructuring)

Actually, I was using ninja when I ran into this problem. Here is the sequence of commands that lead to the error: $> pwd devel/gnucash $mkdir gbuild && cc gbuild $ cmake -D WITH_AQBANKING=OFF -D WITH_OFX=OFF -G Ninja .. && ninja check && ninja install I am attaching po/missing. Note that the fo

Re: cmake failure (was:Re: Source directory restructuring)

On donderdag 10 augustus 2017 14:15:24 CEST Aaron Laws wrote: > I remember getting that error a long time ago, but I don't remember how to > fix it. I think it has something to do with deleting a generated file and > having make re-generate it? It seems like we have a generated file in > version co

Re: cmake failure (was:Re: Source directory restructuring)

On Thu, Aug 10, 2017 at 3:13 AM, Geert Janssens wrote: > On donderdag 10 augustus 2017 07:08:38 CEST Sumit Bhardwaj wrote: > > John and Geert, > > > > As I remembered, I am still having problem with cmake. I have pasted the > > error message below. Is this a known problem? If not, will it be bett

cmake failure (was:Re: Source directory restructuring)

On donderdag 10 augustus 2017 07:08:38 CEST Sumit Bhardwaj wrote: > John and Geert, > > As I remembered, I am still having problem with cmake. I have pasted the > error message below. Is this a known problem? If not, will it be better to > wait for Geert's restructuring and then try to fix it? For

Re: Source directory restructuring

arded message -- > >> From: John Ralls > >> To: Sumit Bhardwaj > >> Cc: gnucash-devel > >> Bcc: > >> Date: Tue, 8 Aug 2017 20:01:44 +0300 > >> Subject: Re: Source directory restructuring > >> > >>> On Aug 8, 2017, at 5

Re: Source directory restructuring

> On Aug 9, 2017, at 9:16 PM, Alex Aycinena wrote: > >> >> >> >> -- Forwarded message -- >> From: John Ralls >> To: Sumit Bhardwaj >> Cc: gnucash-devel >> Bcc: >> Date: Tue, 8 Aug 2017 20:01:44 +0300 >> Subj

Re: Source directory restructuring

> > > > -- Forwarded message -- > From: John Ralls > To: Sumit Bhardwaj > Cc: gnucash-devel > Bcc: > Date: Tue, 8 Aug 2017 20:01:44 +0300 > Subject: Re: Source directory restructuring > > > On Aug 8, 2017, at 5:50 PM, Sumit Bhardwaj wrot

Re: Source directory restructuring

> On Aug 9, 2017, at 8:02 PM, Geert Janssens wrote: > > On woensdag 9 augustus 2017 18:51:52 CEST Geert Janssens wrote: >>> Geert and I use the cmake+ninja build system most of the time and the >>> Windows automated build has been using it for just over a year. I think >>> that it's well tested.

Re: Source directory restructuring

On woensdag 9 augustus 2017 18:51:52 CEST Geert Janssens wrote: > > Geert and I use the cmake+ninja build system most of the time and the > > Windows automated build has been using it for just over a year. I think > > that it's well tested. There's a known problem that the dependency graph > > does

Re: Source directory restructuring

On dinsdag 8 augustus 2017 19:01:44 CEST John Ralls wrote: > > On Aug 8, 2017, at 5:50 PM, Sumit Bhardwaj wrote: > > > > John, > > > > If the plan is to dump autotools, should we ask also devs to make sure > > that > > they can build using cmake? I have had problems in the past and therefore, >

Re: Source directory restructuring

On Mon, Aug 7, 2017 at 7:56 AM, Geert Janssens wrote: > So after my houskeeping message in which I have announced the changes to > src/ > business and src/libqof, I'd like to bring up my eventual goal for the > source > tree. > > My main motivation to do all this restructuring is to simplify. The

Re: Source directory restructuring

> On Aug 8, 2017, at 5:50 PM, Sumit Bhardwaj wrote: > > John, > > If the plan is to dump autotools, should we ask also devs to make sure that > they can build using cmake? I have had problems in the past and therefore, > I have stuck with autotools so far. > > What are the things we want to co

Re: Source directory restructuring

John, If the plan is to dump autotools, should we ask also devs to make sure that they can build using cmake? I have had problems in the past and therefore, I have stuck with autotools so far. What are the things we want to confirm in the cmake toolchain? cmake cmake install cmake check Anything

Re: Source directory restructuring

> On Aug 8, 2017, at 10:29 AM, Geert Janssens > wrote: > > On maandag 7 augustus 2017 21:27:18 CEST John Ralls wrote: >> These are to be top-level directories, so the current src goes away, right? >> The rest assumes that to be the case. >> > Yes, I would drop src. > >> Let's call the libgnuc

Re: Source directory restructuring

On maandag 7 augustus 2017 21:27:18 CEST John Ralls wrote: > These are to be top-level directories, so the current src goes away, right? > The rest assumes that to be the case. > Yes, I would drop src. > Let's call the libgnucash directory libgnucash instead of just lib and keep > lib as the plac

Re: Source directory restructuring

> On Aug 7, 2017, at 2:56 PM, Geert Janssens wrote: > > So after my houskeeping message in which I have announced the changes to src/ > business and src/libqof, I'd like to bring up my eventual goal for the source > tree. > > My main motivation to do all this restructuring is to simplify. Ther

Re: Source directory restructuring

This sounds like a great plan to me. It will definitely make understanding the code easier than the current state. -Sumit On Mon, Aug 7, 2017 at 7:23 AM, Derek Atkins wrote: > Sounds like a great plan to me!!! > > -derek > > Geert Janssens writes: > > > So after my houskeeping message in which

Re: Source directory restructuring

Sounds like a great plan to me!!! -derek Geert Janssens writes: > So after my houskeeping message in which I have announced the changes to src/ > business and src/libqof, I'd like to bring up my eventual goal for the source > tree. > > My main motivation to do all this restructuring is to simp

Source directory restructuring

So after my houskeeping message in which I have announced the changes to src/ business and src/libqof, I'd like to bring up my eventual goal for the source tree. My main motivation to do all this restructuring is to simplify. There are currently plenty of directories and I often have to guess wh