Re: [PATCH] Updated add/edit account window

2006-02-16 Thread Andreas Köhler
Hi, On Wednesday, 15 Feb 2006, 23:25 CET, Chris Shoemaker wrote: > On Wed, Feb 15, 2006 at 06:40:10PM +0100, Andreas Köhler wrote: > > Here is a patch that tries to replace the list store with a filtered > > GncTreeModelAccountTypes. If you do not want to go this way (do not > > think so), there a

Re: [PATCH] Updated add/edit account window

2006-02-15 Thread Chris Shoemaker
On Wed, Feb 15, 2006 at 06:40:10PM +0100, Andreas Köhler wrote: > Here is a patch that tries to replace the list store with a filtered > GncTreeModelAccountTypes. If you do not want to go this way (do not > think so), there are still two open bugs in my own code ;) Just out of curiousity, were you

Re: [PATCH] Updated add/edit account window

2006-02-15 Thread Chris Shoemaker
On Wed, Feb 15, 2006 at 06:40:10PM +0100, Andreas Köhler wrote: > Hi, > > On Monday, 16 Jan 2006, 16:49 CET, Eskil Bylund wrote: > > Here's a patch that updates the add/edit account window. Changes are: > > > > * src/gnome/glade/account.glade > > * src/gnome-utils/dialog-account.c: Clean up the

Re: [PATCH] Updated add/edit account window

2006-02-15 Thread Andreas Köhler
Hi, On Monday, 16 Jan 2006, 16:49 CET, Eskil Bylund wrote: > Here's a patch that updates the add/edit account window. Changes are: > > * src/gnome/glade/account.glade > * src/gnome-utils/dialog-account.c: Clean up the Account dialog. > Replace the account type clist with a GtkComboBox. Update t

Re: [PATCH] Updated add/edit account window

2006-01-29 Thread Chris Shoemaker
On Sun, Jan 29, 2006 at 04:03:51PM +0100, Eskil Bylund wrote: > 2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > > It would definitely be nice to show selection state with checkboxes. > > But it'd also be nice to use the static account types tree model. > > > > What do you think about this:? > > >

Re: [PATCH] Updated add/edit account window

2006-01-29 Thread Eskil Bylund
2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > It would definitely be nice to show selection state with checkboxes. > But it'd also be nice to use the static account types tree model. > > What do you think about this:? > > Keep the selection state private to the filterBy dialog instead of > usin

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Eskil Bylund
2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Thu, Jan 19, 2006 at 09:31:54PM +0100, Eskil Bylund wrote: > > 2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > > > On Thu, Jan 19, 2006 at 08:19:14PM +0100, Eskil Bylund wrote: > > > > > Only that the static tree model probably shouldn't contai

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Chris Shoemaker
On Thu, Jan 19, 2006 at 09:31:54PM +0100, Eskil Bylund wrote: > 2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > > On Thu, Jan 19, 2006 at 08:19:14PM +0100, Eskil Bylund wrote: > > > > Only that the static tree model probably shouldn't contain selection > > > > state. It might be shared by multip

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Eskil Bylund
2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Thu, Jan 19, 2006 at 08:19:14PM +0100, Eskil Bylund wrote: > > > Only that the static tree model probably shouldn't contain selection > > > state. It might be shared by multiple views that want different > > > selections. > > > > > No, of course

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Derek Atkins
Quoting Chris Shoemaker <[EMAIL PROTECTED]>: To summarize above: I would like to remove the GtkTreeView specific functions from the model and make the Filter dialog use its own model for storing selection state. It would definitely be nice to show selection state with checkboxes. But it'd also

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Chris Shoemaker
On Thu, Jan 19, 2006 at 08:19:14PM +0100, Eskil Bylund wrote: > > Only that the static tree model probably shouldn't contain selection > > state. It might be shared by multiple views that want different > > selections. > > > No, of course. See above. > > > Maybe that's why you wanted to provide t

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Eskil Bylund
2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Thu, Jan 19, 2006 at 07:21:49PM +0100, Eskil Bylund wrote: > > While we're at GncTreeModelAccountTypes, there are some other changes > > I would like to make. > > 1. Remove gnc_tree_model_account_types_get/set_selection, which > > handles the sel

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread David Hampton
On Thu, 2006-01-19 at 19:21 +0100, Eskil Bylund wrote: > While we're at GncTreeModelAccountTypes, there are some other changes > I would like to make. > 1. Remove gnc_tree_model_account_types_get/set_selection, which > handles the selection of a GtkTreeView. > 2. Rename gnc_tree_model_account_type

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Chris Shoemaker
On Thu, Jan 19, 2006 at 07:21:49PM +0100, Eskil Bylund wrote: > While we're at GncTreeModelAccountTypes, there are some other changes > I would like to make. > 1. Remove gnc_tree_model_account_types_get/set_selection, which > handles the selection of a GtkTreeView. They are used by the account pag

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Eskil Bylund
2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Wed, Jan 18, 2006 at 02:10:28PM +0100, Eskil Bylund wrote: > > 2006/1/17, Chris Shoemaker <[EMAIL PROTECTED]>: > > > If you want to continue with this, here's what I suggest: > > > > > > 1) move the filter function into gnc-tree-model-account-t

Re: [PATCH] Updated add/edit account window

2006-01-19 Thread Chris Shoemaker
On Wed, Jan 18, 2006 at 02:10:28PM +0100, Eskil Bylund wrote: > 2006/1/17, Chris Shoemaker <[EMAIL PROTECTED]>: > > If you want to continue with this, here's what I suggest: > > > > 1) move the filter function into gnc-tree-model-account-types.c. I > > think it can be private because... > > 2)

Re: [PATCH] Updated add/edit account window

2006-01-18 Thread Eskil Bylund
2006/1/17, Chris Shoemaker <[EMAIL PROTECTED]>: > If you want to continue with this, here's what I suggest: > > 1) move the filter function into gnc-tree-model-account-types.c. I > think it can be private because... > 2) add a public convenience routine to > gnc-tree-model-account-types.[ch] t

Re: [PATCH] Updated add/edit account window

2006-01-16 Thread Chris Shoemaker
On Tue, Jan 17, 2006 at 12:47:02AM +0100, Eskil Bylund wrote: > 2006/1/16, Eskil Bylund <[EMAIL PROTECTED]>: > > Hi, > > > > Here's a patch that updates the add/edit account window. Changes are: > > > > * src/gnome/glade/account.glade > > * src/gnome-utils/dialog-account.c: Clean up the Account d

Re: [PATCH] Updated add/edit account window

2006-01-16 Thread Derek Atkins
Quoting Eskil Bylund <[EMAIL PROTECTED]>: Attached is the new patch using gnc-tree-model-account-types, with the change log being the same as above. Please check the glade file since it contains some string changes, among other things... Should I submit a patch that hides the currency account t

Re: [PATCH] Updated add/edit account window

2006-01-16 Thread Derek Atkins
Quoting Chris Shoemaker <[EMAIL PROTECTED]>: [snip] Is that what Eskil needs for dialog-account.c? No, it's what I want in order to Deprecate Currency accounts. -chris -derek -- Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory Member, MIT Student Information Processing

Re: [PATCH] Updated add/edit account window

2006-01-16 Thread Chris Shoemaker
On Mon, Jan 16, 2006 at 11:30:49AM -0500, Derek Atkins wrote: > Chris, > > Quoting Chris Shoemaker <[EMAIL PROTECTED]>: > > >Hello Eskil, > > > > Instead of creating and populating a GtkListStore for the Account > >types, could you please use the pre-made GtkTreeModel offered by > >gnc-tree-model

Re: [PATCH] Updated add/edit account window

2006-01-16 Thread Derek Atkins
Chris, Quoting Chris Shoemaker <[EMAIL PROTECTED]>: Hello Eskil, Instead of creating and populating a GtkListStore for the Account types, could you please use the pre-made GtkTreeModel offered by gnc-tree-model-account-types.[ch]? (Preferrably "Method 1".) That way, you don't have to worry

Re: [PATCH] Updated add/edit account window

2006-01-16 Thread Chris Shoemaker
On Mon, Jan 16, 2006 at 04:49:32PM +0100, Eskil Bylund wrote: > Hi, > > Here's a patch that updates the add/edit account window. Changes are: > > * src/gnome/glade/account.glade > * src/gnome-utils/dialog-account.c: Clean up the Account dialog. > Replace the account type clist with a GtkComboBo