Re: [GNC-dev] Bug 796725

2018-08-16 Thread Geert Janssens
Op woensdag 15 augustus 2018 15:43:37 CEST schreef John Ralls: > I was actually thinking of date ranges on report options, but yeah, having > both “before” and “on or before” seems redundant. > Technically this is true although that's like stating in sql queries '<' is redundant because you can s

Re: [GNC-dev] Bug 796725

2018-08-15 Thread John Ralls
I was actually thinking of date ranges on report options, but yeah, having both “before” and “on or before” seems redundant. Regards, John Ralls > On Aug 15, 2018, at 2:47 AM, Robert Fewell <14ubo...@gmail.com> wrote: > > So really in the FIND dialogue the Date find option only needs two or thr

Re: [GNC-dev] Bug 796725

2018-08-15 Thread Robert Fewell
So really in the FIND dialogue the Date find option only needs two or three possibilities "is before or on" using gnc_dmy2time64_end() to change entry date to 23:59:59 "is on" with the QofDateMatch set to QOF_DATE_MATCH_DAY ( this changes the compared dates with 'time64CanonicalDayTime' ) "is

Re: [GNC-dev] Bug 796725

2018-08-14 Thread John Ralls
> On Aug 14, 2018, at 6:55 AM, Robert Fewell <14ubo...@gmail.com> wrote: > > I have been looking at this one and know what is wrong but not sure if my > fix is valid. > > It is to do with searching for transactions by posted date and returning > the wrong number of transactions for the required