Re: [GNC-dev] [GNC] Transaction Report Sign Reverses

2019-10-13 Thread Christopher Lam
Yes, that is correct. The Transaction Report engine was pulled out into a separate file because it was reused in numerous reports. On Sun, 13 Oct 2019 at 14:50, David T. wrote: > Chris, > > Thanks for returning to this. > > I see that this is a patch file for trep-engine.scm. My only experience

Re: [GNC-dev] [GNC] Transaction Report Sign Reverses

2019-10-13 Thread David T. via gnucash-devel
Chris, Thanks for returning to this. I see that this is a patch file for trep-engine.scm. My only experience using patches was when I was on a Mac; now I am on Windows, and wonder which tools to use to apply your patch. Moreover, I am using 3.5, and do not find trep-engine.scm anywhere in C

Re: [GNC-dev] [GNC] Transaction Report Sign Reverses

2019-10-13 Thread Christopher Lam
Hi David, I'd had a review of transaction-report and can attempt fix signs for subtotals when sorting by 'account name'. The difficult issue remains how to handle reversals when sorting by 'other account name'. I think it's buggy and not sure how to handle it. Try this patch to trep-engine.scm in a