Re: Patch to partially add recursion to budgets

2006-10-11 Thread Chris Shoemaker
On Tue, Oct 10, 2006 at 08:43:35AM -0500, Gregory Alexander wrote: > Alright, I got the patch updated. I like the idea of using the unset > value. I was just unfarmiliar with the value structure holding code. Ok, I've committed this to trunk as 15009, with some slight tweaks. > I will note that

Re: Patch to partially add recursion to budgets

2006-10-10 Thread Gregory Alexander
Alright, I got the patch updated. I like the idea of using the unset value. I was just unfarmiliar with the value structure holding code. I will note that there will be minor migration problems from old versions, since values that are currently 0 will display as 0, and values that are currently

Re: Patch to partially add recursion to budgets

2006-10-03 Thread Chris Shoemaker
On Mon, Oct 02, 2006 at 08:26:07PM -0500, Gregory Alexander wrote: > Alright, I have a patch. > > This may start a flame, but I added a new GNC_ERROR_UNSET error code. > I added this because none of the existing errors was really > appropriate for a value that simply wasn't set yet. I'm open to o

Re: Patch to partially add recursion to budgets

2006-10-02 Thread Gregory Alexander
Alright, I have a patch. This may start a flame, but I added a new GNC_ERROR_UNSET error code. I added this because none of the existing errors was really appropriate for a value that simply wasn't set yet. I'm open to other names like GNC_ERROR_UNINITIALIZED, and would reluctantly change it to

Re: Patch to partially add recursion to budgets

2006-09-28 Thread Chris Shoemaker
On Thu, Sep 28, 2006 at 02:30:16AM -0500, Gregory Alexander wrote: > I apologize for the rich-text formatting, I needed it to get the mock-ups to > look right. > > Hmmm, thanks for pointing me at that file. Now I understand the design > philosophy behind what I thought was a functional bug. I th

Re: Patch to partially add recursion to budgets

2006-09-28 Thread Gregory Alexander
I apologize for the rich-text formatting, I needed it to get the mock-ups to look right. Hmmm, thanks for pointing me at that file. Now I understand the design philosophy behind what I thought was a functional bug. I think the reason I found it counter-intuitive is that this is different from ho

Re: Patch to partially add recursion to budgets

2006-09-27 Thread Chris Shoemaker
On Wed, Sep 27, 2006 at 12:59:34AM -0500, Gregory Alexander wrote: > Budgets are almost what I need to get gnucash to do what I want. > > I'm having a problem in that budget behavior is inconsistently > recursive over accounts. I have a bug open on that. Honestly, I read that bug once, and didn'

Patch to partially add recursion to budgets

2006-09-26 Thread Gregory Alexander
Budgets are almost what I need to get gnucash to do what I want. I'm having a problem in that budget behavior is inconsistently recursive over accounts. I have a bug open on that. Attached is a patch that starts along the path of making recursion optional for budget calls, but stops short of pr