Re: PATCH: fix KVP bug/allow gnc_numeric to be a GBoxed value

2007-04-17 Thread Derek Atkins
"Daniel Espinosa" <[EMAIL PROTECTED]> writes: > I have added as GType the following: > > GUID > KVP > QofCollection (as a direct GObject derived class) I'm not sure we need a QofCollection per se (I dont think GnuCash actually uses that functionality from QOF).. But yeah, I see that adding a GUI

Re: PATCH: fix KVP bug/allow gnc_numeric to be a GBoxed value

2007-04-13 Thread Daniel Espinosa
Sorry forget to add links: 2007/4/13, Daniel Espinosa <[EMAIL PROTECTED]>: > 2007/4/13, Derek Atkins <[EMAIL PROTECTED]>: > > "Daniel Espinosa" <[EMAIL PROTECTED]> writes: > > > > > Derek: > > > I have added some types declared in gnc-engine.h file as string to > > > GType in my gobject-engine-dev

Re: PATCH: fix KVP bug/allow gnc_numeric to be a GBoxed value

2007-04-13 Thread Daniel Espinosa
2007/4/13, Derek Atkins <[EMAIL PROTECTED]>: > "Daniel Espinosa" <[EMAIL PROTECTED]> writes: > > > Derek: > > I have added some types declared in gnc-engine.h file as string to > > GType in my gobject-engine-dev, like the one for gnc_numeric Phil > > does, then this could be added to your branch wi

Re: PATCH: fix KVP bug/allow gnc_numeric to be a GBoxed value

2007-04-13 Thread Derek Atkins
"Daniel Espinosa" <[EMAIL PROTECTED]> writes: > Derek: > I have added some types declared in gnc-engine.h file as string to > GType in my gobject-engine-dev, like the one for gnc_numeric Phil > does, then this could be added to your branch with out alter the > system, and could help Phil in he's b

Re: PATCH: fix KVP bug/allow gnc_numeric to be a GBoxed value

2007-04-12 Thread Daniel Espinosa
Derek: I have added some types declared in gnc-engine.h file as string to GType in my gobject-engine-dev, like the one for gnc_numeric Phil does, then this could be added to your branch with out alter the system, and could help Phil in he's branch. 2007/4/9, Derek Atkins <[EMAIL PROTECTED]>: > I

Re: PATCH: fix KVP bug/allow gnc_numeric to be a GBoxed value

2007-04-09 Thread Derek Atkins
I wonder if we should add a test-case for this kvp issue so we don't regress? Also, this patch should've been split into two. I've done that myself as I applied them. -derek Phil Longstaff <[EMAIL PROTECTED]> writes: > The attached patch does two things: > > 1) Fixes a KVP bug where kvp_frame_

PATCH: fix KVP bug/allow gnc_numeric to be a GBoxed value

2007-04-07 Thread Phil Longstaff
The attached patch does two things: 1) Fixes a KVP bug where kvp_frame_add_value_nc() wouldn't properly create a frame which didn't previously exist. The problem was that by the time the routine realized it needed to create the path, the variable holding the path had been overwritten. 2) Add