Jesse Weinstein writes:
> I found safe_strcmp in qofutil.h -- but it's not at all clear to me how
> or whether I can or should #include that into gnc-sx-instance-model.c
> where my patch touches. Advise? As for having using a utf8-aware
> comparison -- I'm open to suggestions, but, I'm not aware
I found safe_strcmp in qofutil.h -- but it's not at all clear to me how
or whether I can or should #include that into gnc-sx-instance-model.c
where my patch touches. Advise? As for having using a utf8-aware
comparison -- I'm open to suggestions, but, I'm not aware of what if any
is already in use,
Jesse Weinstein writes:
> +static gint
> +_compare_GncSxVariables(gconstpointer a, gconstpointer b)
> +{
> + return strcmp(((const GncSxVariable*)a)->name, ((const
> GncSxVariable*)b)->name);
> +}
You should probably use safe_strcmp() here (in case ->name is NULL).
Or maybe even a utf8-capable
On Saturday 20 February 2010, Jesse Weinstein wrote:
> This patch causes the SX "Since Last Run..." dialog to display SX
> variables in ASCII order, rather than ordering by hashvalue (i.e. no
> order at all) as was done previously.
>
> I previously, incorrectly, sent this to the list mixed in with
This patch causes the SX "Since Last Run..." dialog to display SX
variables in ASCII order, rather than ordering by hashvalue (i.e. no
order at all) as was done previously.
I previously, incorrectly, sent this to the list mixed in with another
patch; I'm resending it separately, as suggested on IR
Sorry about mixing three patches in one; I don't (yet) know how to make
bzr separate them. I'll do it by hand if requested, though.
All three of these patches are tiny, less than 10 lines for each.
First, I modified the sx variable handling code to sort the variables
when it turns them into a
