Re: Compile test-core in C++

2014-11-26 Thread John Ralls
> On Nov 26, 2014, at 12:55 PM, Aaron Laws wrote: > Mr. Rall’s Ralls’s. I’m plural. ;-) > > Right. The C tests (using the gtest framework) shouldn't see any C++. > Actually, the C tests shouldn't change at all (ideally) in response to your > work. It sounds like your understanding is corre

Re: Compile test-core in C++

2014-11-26 Thread Aaron Laws
On Sat, Nov 22, 2014 at 10:02 AM, Chenxiong Qi wrote: > I converted QofCollection_s to a C++ class named QofCollection placed > in same header file src/libqof/qof/qofid.h, I would advise against putting the class declaration into this file. It can certainly be done by following Mr. Rall's sugge

Re: Compile test-core in C++

2014-11-22 Thread John Ralls
> On Nov 22, 2014, at 7:02 AM, Chenxiong Qi wrote: > > On Fri, Nov 21, 2014 at 3:51 AM, Aaron Laws wrote: >> On Thu, Nov 20, 2014 at 9:58 AM, Chenxiong Qi wrote: >>> >>> Is it acceptable that I rename the new class to >>> another name temporarily, such as QofCollectionClass, and keep the new

Re: Compile test-core in C++

2014-11-22 Thread Chenxiong Qi
On Fri, Nov 21, 2014 at 3:51 AM, Aaron Laws wrote: > On Thu, Nov 20, 2014 at 9:58 AM, Chenxiong Qi wrote: >> >> Is it acceptable that I rename the new class to >> another name temporarily, such as QofCollectionClass, and keep the new >> class implementation and original one's existing simultaneou

Re: Compile test-core in C++

2014-11-20 Thread John Ralls
On Nov 20, 2014, at 6:58 AM, Chenxiong Qi wrote: > On Thu, Nov 20, 2014 at 10:36 PM, John Ralls wrote: >> >>> On Nov 20, 2014, at 5:37 AM, Chenxiong Qi wrote: >>> >>> On Wed, Nov 19, 2014 at 12:17 AM, John Ralls wrote: >>> &

Re: Compile test-core in C++

2014-11-20 Thread Aaron Laws
On Thu, Nov 20, 2014 at 9:58 AM, Chenxiong Qi wrote: > Is it acceptable that I rename the new class to > another name temporarily, such as QofCollectionClass, and keep the new > class implementation and original one's existing simultaneously. I > know this looks strange, but the change only affec

Re: Compile test-core in C++

2014-11-20 Thread Chenxiong Qi
On Thu, Nov 20, 2014 at 10:36 PM, John Ralls wrote: > >> On Nov 20, 2014, at 5:37 AM, Chenxiong Qi wrote: >> >> On Wed, Nov 19, 2014 at 12:17 AM, John Ralls wrote: >> >>> Why do you want to compile test-core in C++? >>> >> >> src/tes

Re: Compile test-core in C++

2014-11-20 Thread John Ralls
> On Nov 20, 2014, at 5:37 AM, Chenxiong Qi wrote: > > On Wed, Nov 19, 2014 at 12:17 AM, John Ralls wrote: > >> Why do you want to compile test-core in C++? >> > > src/test-core/unittest-support.h includes qof.h Lots of code includes qof.h. That's not a

Re: Compile test-core in C++

2014-11-20 Thread Chenxiong Qi
looking forward to your pull request or patch. If you want > to go the patch route, please open a bug report. > when the code is ready for review i'll create a PR. now, still several works need to do. > Why do you want to compile test-core in C++? > src/test-core/unittest-suppo

Re: Compile test-core in C++

2014-11-18 Thread Aaron Laws
On Tue, Nov 18, 2014 at 10:10 AM, Chenxiong Qi wrote: > Hi, > > I've converted QofCollection to a C++ class. A side-effect is that I > have to make src/test-core be able to compile in C++. Although QofCollection will be a C++ class, you should be retaining the C interface! The existing tests (s

Re: Compile test-core in C++

2014-11-18 Thread John Ralls
thout > errors. > > BTW, besides the conversion to C++ class, I will write unit tests to > ensure new QofCollection class works as expected. Great! Thanks! I'm looking forward to your pull request or patch. If you want to go the patch route, please open a bug report. Why do

Compile test-core in C++

2014-11-18 Thread Chenxiong Qi
Hi, I've converted QofCollection to a C++ class. A side-effect is that I have to make src/test-core be able to compile in C++. I'm an absolute newbie to autotools, still not get a workable solution so far after doing some research on this. Could you give some guide how to accomplish this conversio