Re: Bug 756469

2016-01-14 Thread Geert Janssens
On Thursday 14 January 2016 10:47:06 Mike Evans wrote: > I occurs to me that the regex for with-quotes now also accepts fields > without-quotes too, so the importer doesn't need the without-quotes > options. I don't think they are equivalent and their choice depends on the input format of the use

Re: Bug 756469

2016-01-14 Thread Mike Evans
I occurs to me that the regex for with-quotes now also accepts fields without-quotes too, so the importer doesn't need the without-quotes options. Also I'm wondering if the custom regex option is required or likely to be ever used by anyone? I'd file a separate bug/enhancement for this. Mike

Re: Bug 756469

2016-01-13 Thread Mike Evans
On Tue, 12 Jan 2016 17:48:58 +0100 Geert Janssens wrote: > On Tuesday 12 January 2016 10:11:25 Derek Atkins wrote: > > Hi, > > > > On Tue, January 12, 2016 9:52 am, Mike Evans wrote: > > > Hi Geert. > > > > > > I'd appreciate some advice on this bug, since you were that last > > > person to tou

Re: Bug 756469

2016-01-12 Thread Geert Janssens
On Tuesday 12 January 2016 10:11:25 Derek Atkins wrote: > Hi, > > On Tue, January 12, 2016 9:52 am, Mike Evans wrote: > > Hi Geert. > > > > I'd appreciate some advice on this bug, since you were that last > > person to touch the (makes my head hurt) regex. > > > > In file dialog-bi-import-gui.c

Re: Bug 756469

2016-01-12 Thread Derek Atkins
Hi, On Tue, January 12, 2016 9:52 am, Mike Evans wrote: > Hi Geert. > > I'd appreciate some advice on this bug, since you were that last person to > touch the (makes my head hurt) regex. > > In file dialog-bi-import-gui.c line 328 The regex for description, and > notes is currently: > > ((?[^\",]*

Bug 756469

2016-01-12 Thread Mike Evans
Hi Geert. I'd appreciate some advice on this bug, since you were that last person to touch the (makes my head hurt) regex. In file dialog-bi-import-gui.c line 328 The regex for description, and notes is currently: ((?[^\",]*)|\"(?[^\"]*)\")\" I'm not a regex guru but it seems to me that losin