Re: [Patch] reworked advanced-portfolio.scm

2006-02-23 Thread Andrew Sackville-West
On Thu, 23 Feb 2006 22:46:13 +0100 Herbert Thoma <[EMAIL PROTECTED]> wrote: > > Hmm, I usually do a get-quotes once a day, so I think I have > a reasonable price. > > Anyway, how do you get price data from the transaction? > Say you buy 10 shares X for 100 EUR and the report currency is USD. >

Re: [Patch] reworked advanced-portfolio.scm

2006-02-23 Thread Herbert Thoma
Andrew Sackville-West wrote: On Thu, 23 Feb 2006 19:45:28 +0100 Herbert Thoma <[EMAIL PROTECTED]> wrote: > Most of my securities are denominated in Euro. I own some in USD as well, but I bought them for a certain Euro amount and I will sell them for Euro. So I get a cost basis in Euro from the

Re: [Patch] reworked advanced-portfolio.scm

2006-02-23 Thread Andrew Sackville-West
On Thu, 23 Feb 2006 19:45:28 +0100 Herbert Thoma <[EMAIL PROTECTED]> wrote: > Hi! > > I yust want to throw in my 2 cents because I worked > on this report a long time ago, i.e. it is in its current > shape because it fits my needs. > > Let me explain my usage scenario: > > Most of my securities

Re: [Patch] reworked advanced-portfolio.scm

2006-02-23 Thread Herbert Thoma
Hi! I yust want to throw in my 2 cents because I worked on this report a long time ago, i.e. it is in its current shape because it fits my needs. Let me explain my usage scenario: Most of my securities are denominated in Euro. I own some in USD as well, but I bought them for a certain Euro amou

Re: [Patch] reworked advanced-portfolio.scm

2006-02-23 Thread Eildert Groeneveld
On Thursday 23 February 2006 19:31, Andrew Sackville-West wrote: > > one account > > <> > > it looks to me like that one account has no shares in it. This is correct. Furthermore, it had a negative balance. I just changed that to a zero balance and, it works now. > It was amistake > on my part u

Re: [Patch] reworked advanced-portfolio.scm

2006-02-23 Thread Andrew Sackville-West
On Sun, 19 Feb 2006 10:13:13 +0100 Eildert Groeneveld <[EMAIL PROTECTED]> wrote: > Andrew > > I seem to know when the error occurs: I have a set of stocks and among them > one account <> it looks to me like that one account has no shares in it. It was amistake on my part using (not price) inst

Re: [Patch] reworked advanced-portfolio.scm

2006-02-23 Thread Mike Alexander
--On February 22, 2006 11:44:26 AM -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: this caused problems because the exchange-fn doesn't work right without a pricedb, so far as I can tell. i haven't read them in detail yet, but will. If you don't have a pricedb you don't have currency e

Re: [Patch] reworked advanced-portfolio.scm

2006-02-22 Thread Andrew Sackville-West
On Wed, 22 Feb 2006 10:26:57 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: > Andrew Sackville-West wrote: > > >On Tue, 21 Feb 2006 19:14:33 -0700 > >Mark Johnson <[EMAIL PROTECTED]> wrote: > > > > > >>As far as lots on hand go, is it first-in-first-out or > >>first-in-last-out? Does this vary

Re: [Patch] reworked advanced-portfolio.scm

2006-02-22 Thread Andrew Sackville-West
On Wed, 22 Feb 2006 13:11:44 -0500 Mike Alexander <[EMAIL PROTECTED]> wrote: > --On February 21, 2006 3:54:59 PM -0800 Andrew Sackville-West > <[EMAIL PROTECTED]> wrote: > > > I'm rewriting it so that it tracks two sets of prices in parallel buy > > checking the pricedb and the txn's themselves.

Re: [Patch] reworked advanced-portfolio.scm

2006-02-22 Thread Mike Alexander
--On February 21, 2006 3:54:59 PM -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: I'm rewriting it so that it tracks two sets of prices in parallel buy checking the pricedb and the txn's themselves. Then report back the numbers based on whichever of these two prices is "closer" to the re

Re: [Patch] reworked advanced-portfolio.scm

2006-02-22 Thread Mark Johnson
Andrew Sackville-West wrote: On Tue, 21 Feb 2006 19:14:33 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: As far as lots on hand go, is it first-in-first-out or first-in-last-out? Does this vary from country to country? I know this varies. I think in the US (been too lo

Re: [Patch] reworked advanced-portfolio.scm

2006-02-21 Thread Andrew Sackville-West
On Tue, 21 Feb 2006 19:14:33 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: > Andrew Sackville-West wrote: > > >Alright gang, so here's the sit. on the advanced-portfolio report: > > > >I'm rewriting it so that it tracks two sets of prices in parallel buy > >checking the pricedb and the txn's the

Re: [Patch] reworked advanced-portfolio.scm

2006-02-21 Thread Mark Johnson
Andrew Sackville-West wrote: Alright gang, so here's the sit. on the advanced-portfolio report: I'm rewriting it so that it tracks two sets of prices in parallel buy checking the pricedb and the txn's themselves. Then report back the numbers based on whichever of these two prices is "closer"

Re: [Patch] reworked advanced-portfolio.scm

2006-02-21 Thread Andrew Sackville-West
Alright gang, so here's the sit. on the advanced-portfolio report: I'm rewriting it so that it tracks two sets of prices in parallel buy checking the pricedb and the txn's themselves. Then report back the numbers based on whichever of these two prices is "closer" to the report date. The idea bei

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-20 Thread Mike Alexander
--On February 20, 2006 1:47:57 PM -0500 Derek Atkins <[EMAIL PROTECTED]> wrote: Personally, I'm less worried about translating across currencies than I am about getting a proper stock->currency price. Let's get the report working "correctly" for a single currency, and then we can add in suppor

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-20 Thread Derek Atkins
Quoting Mike Alexander <[EMAIL PROTECTED]>: --On February 20, 2006 9:15:05 AM -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: One thing I would add to the discussion is to point out that the pricedb is used for two things in this report (and elsewhere). It contains prices in some curr

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-20 Thread Mike Alexander
--On February 20, 2006 9:15:05 AM -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: One thing I would add to the discussion is to point out that the pricedb is used for two things in this report (and elsewhere). It contains prices in some currency for the commodities (stocks, bonds, etc.)

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-20 Thread Andrew Sackville-West
On Mon, 20 Feb 2006 03:45:23 -0500 Mike Alexander <[EMAIL PROTECTED]> wrote: > --On February 19, 2006 1:56:38 PM -0800 Andrew Sackville-West > <[EMAIL PROTECTED]> wrote: > > > > > It should IMO also use transactions for current value and make a > > decision as to which is more accurate, or close

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-20 Thread Mike Alexander
--On February 19, 2006 1:56:38 PM -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: It should IMO also use transactions for current value and make a decision as to which is more accurate, or closer in date to the report date. but only use buy or sell transactions as those are the only one

Re: [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Eildert Groeneveld
Andrew just wondering: did the patch make it into svn? cause if it did it did not solve my problem: ;;; WARNING (wrong arguments for gnc:make-gnc-monetary: #f #< num: -736000 denom: 100>) In /usr/local/share/gnucash/guile-modules/gnucash/report/advanced-portfolio.scm: ... 184: 51 (let

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Andrew Sackville-West
On Sun, 19 Feb 2006 14:43:14 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: > Derek Atkins wrote: > > > Quoting Andrew Sackville-West <[EMAIL PROTECTED]>: > > > >> On Sun, 19 Feb 2006 12:20:42 -0800 > >> Andrew Sackville-West <[EMAIL PROTECTED]> wrote: > >> > >>> <> > >>> > >>> I've done some more

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Mark Johnson
Derek Atkins wrote: Quoting Andrew Sackville-West <[EMAIL PROTECTED]>: On Sun, 19 Feb 2006 12:20:42 -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: <> I've done some more testing using different options for price source and whether to show gains or not and the report, as currently mo

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Derek Atkins
Quoting Andrew Sackville-West <[EMAIL PROTECTED]>: On Sun, 19 Feb 2006 12:20:42 -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: <> I've done some more testing using different options for price source and whether to show gains or not and the report, as currently modified in my tree show

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Andrew Sackville-West
On Sun, 19 Feb 2006 12:20:42 -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: ><> > > I've done some more testing using different options for price source > and whether to show gains or not and the report, as currently modified > in my tree shows no difference between these various settings

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Andrew Sackville-West
On Sun, 19 Feb 2006 15:08:55 +0100 Christian Stimming <[EMAIL PROTECTED]> wrote: > Hi Andrew and Mark, > > Am Samstag, 18. Februar 2006 18:20 schrieb Mark Johnson: > > >2) you can always come in the next day and record the current price for > > > the fund so that the pricedb shows the current val

Re: [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Derek Atkins
Andrew Sackville-West <[EMAIL PROTECTED]> writes: >> > In >> > /usr/local/share/gnucash/guile-modules/gnucash/report/advanced-portfolio.scm: >> >... >> > 186: 51 (let* (# # # # ...) (if price-is-dirty #) (for-each # #) ...) >> > 315: 52* (if (or include-empty (not #)) (let* (# # # ...) (if #

Re: reports and prices [Patch] reworked advanced-portfolio.scm

2006-02-19 Thread Christian Stimming
Hi Andrew and Mark, Am Samstag, 18. Februar 2006 18:20 schrieb Mark Johnson: > >2) you can always come in the next day and record the current price for > > the fund so that the pricedb shows the current value. Make sense? the > > only thing you'll lose will be the price history. Its okay that you

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Andrew Sackville-West
On Sat, 18 Feb 2006 18:38:27 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: > Andrew Sackville-West wrote: > > >On Sat, 18 Feb 2006 10:20:24 -0700 > >Mark Johnson <[EMAIL PROTECTED]> wrote: > > > > > [...] > > >>True. What about the possibility of reports based upon the pricedb > >>entries?

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Mark Johnson
Andrew Sackville-West wrote: On Sat, 18 Feb 2006 10:20:24 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: [...] True. What about the possibility of reports based upon the pricedb entries? Eg. a graph of the price history. Such entries would produce unwelcome blips. I'm just t

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Andrew Sackville-West
On Sat, 18 Feb 2006 15:44:38 -0500 Derek Atkins <[EMAIL PROTECTED]> wrote: > Make sure you're responding to the list, please heh. you too ;) > > Quoting Andrew Sackville-West <[EMAIL PROTECTED]>: > > >> E.g., here's a problem case: > >> > >> Buy 100 shares on date T0 > >> pricedb entry

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Derek Atkins
Make sure you're responding to the list, please Quoting Andrew Sackville-West <[EMAIL PROTECTED]>: E.g., here's a problem case: Buy 100 shares on date T0 pricedb entry on date T1 pricedb entry on date T2 Sell 50 shares on date T3 Let's assume that delta-t is something like a week

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Andrew Sackville-West
On Sat, 18 Feb 2006 10:20:24 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: > Andrew Sackville-West wrote: > > >On Fri, 17 Feb 2006 19:58:24 -0700 > >Mark Johnson <[EMAIL PROTECTED]> wrote: > > > > > > > >> [...] > >> > >>Automatically, creating entries in the pricedb for any buy, sell or > >>"

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Andrew Sackville-West
On Sat, 18 Feb 2006 10:20:44 -0500 Derek Atkins <[EMAIL PROTECTED]> wrote: > This should have gone back to the list so Andrew can see it. > > -derek > > Quoting Eildert Groeneveld <[EMAIL PROTECTED]>: > > > Derek > > > > not much luck I am afraid. patch make make install all wentrthrough nicely

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Mark Johnson
Derek Atkins wrote: a) you shouldn't compute realized gain from pricedb -- it should be computed from the actual transaction data. b) you CAN compute unrealized gain from pricedb OR txn data. c) I do not believe you should exclude stocks without pricedb entries from the totals. It gi

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Mark Johnson
Andrew Sackville-West wrote: On Fri, 17 Feb 2006 19:58:24 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: [...] Automatically, creating entries in the pricedb for any buy, sell or "similar action" strikes me as a rather dicey thing to do. I offer two similar recent use cases I have had to

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Derek Atkins
Andrew Sackville-West <[EMAIL PROTECTED]> writes: > It uses the > pricedb to get the most recent price for a commodity and uses that > price to calculate the value of a particular holding. It seems > people are buying stocks but making no pricedb entry at the time of > purchase. This breaks the

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Derek Atkins
Andrew... Any chance you could add 80-character line breaks to your messages? Andrew Sackville-West <[EMAIL PROTECTED]> writes: > 3) a stock account with shares in it but with no pricedb entry. In > this case, I made the assumption that the file was broken. This is unfortunately an incorrect a

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Derek Atkins
This should have gone back to the list so Andrew can see it. -derek Quoting Eildert Groeneveld <[EMAIL PROTECTED]>: Derek not much luck I am afraid. patch make make install all wentrthrough nicely. But this is the result: Anything else I could do? greetings Eildert ;;; WARNING (wrong ar

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Derek Atkins
No, it hasn't made it into SVN. Any chance you could apply it to your sandbox and test it?If it works for you could you let me know? Then you could "svn revert" the advanced-portfoliio.scm so it doesn't conflict when I do commit it. Thanks! -derek Quoting Eildert Groeneveld <[EMAIL PROTEC

Re: [Patch] reworked advanced-portfolio.scm

2006-02-18 Thread Eildert Groeneveld
Andrew just wondering: did the patch make it into svn? cause if it did it did not solve my problem: ;;; WARNING (wrong arguments for gnc:make-gnc-monetary: #f #< num: -736000 denom: 100>) In /usr/local/share/gnucash/guile-modules/gnucash/report/advanced-portfolio.scm: ... 184: 51 (let

Re: [Patch] reworked advanced-portfolio.scm

2006-02-17 Thread Andrew Sackville-West
On Fri, 17 Feb 2006 19:58:24 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: > Andrew Sackville-West wrote: > > >3) a stock account with shares in it but with no pricedb entry. In this > >case, I made the assumption that the file was broken. There should always be > >a pricedb entry if there are

Re: [Patch] reworked advanced-portfolio.scm

2006-02-17 Thread Andrew Sackville-West
On Fri, 17 Feb 2006 19:58:24 -0700 Mark Johnson <[EMAIL PROTECTED]> wrote: please reply to the list. > Andrew Sackville-West wrote: > > >3) a stock account with shares in it but with no pricedb entry. In this > >case, I made the assumption that the file was broken. There should always be > >a

Re: [Patch] reworked advanced-portfolio.scm

2006-02-17 Thread Mark Johnson
Andrew Sackville-West wrote: 3) a stock account with shares in it but with no pricedb entry. In this case, I made the assumption that the file was broken. There should always be a pricedb entry if there are any shares in an account, IMO. Probably the code should be fixed so that any buy or se

Re: [Patch] reworked advanced-portfolio.scm

2006-02-17 Thread Andrew Sackville-West
crap bad diffs file there, please disregard and use the attached. A On Fri, 17 Feb 2006 16:33:43 -0800 Andrew Sackville-West <[EMAIL PROTECTED]> wrote: > Okay, the advanced portfolio report was broken in a number of ways. I've > masssaged it pretty well I think, but made some assumptions about

[Patch] reworked advanced-portfolio.scm

2006-02-17 Thread Andrew Sackville-West
Okay, the advanced portfolio report was broken in a number of ways. I've masssaged it pretty well I think, but made some assumptions about how it should behave. Essentially, there are three cases we encounter, listed below: 1). a normal, properly formed stock account with pricedb entries etc. I