On 7 Mar 2020, at 5:22, Christopher Lam wrote:
Ok I think your changes are fine. I don't understand qof_log_check I'd
hope it's not slow.
I just pushed the change.
qof_log_check is called a *lot* and I don't think it's a problem. It
does a couple of hash table lookups and a couple of string
On Sat, 7 Mar 2020 at 06:18, Mike Alexander wrote:
> I understand. Avoiding the call to strify is a good idea and I don't
> intend to change that. I was simply pointing out that evaluating the args
> to gnc:debug may also take some time. In the case you mention presumably
> pricelist already exis
On 7 Mar 2020, at 0:39, Christopher Lam wrote:
I'd thought that the log level would be an invariant per session. If
log levels could be amended mid-session I'd like to see how.
Call qof-log-set-level. It works fine without the most recent change to
gnc:debug. I put a few calls to it into
g
Hi Mike.
I'd thought that the log level would be an invariant per session. If log
levels could be amended mid-session I'd like to see how.
The gnc:debug was optimized because there was (gnc:debug pricelist) whereby
a long pricelist (which is realistic) would obligatorily lead to
string-join and m
I spent some time yesterday figuring out why gnc:debug never produced
any output regardless of the gnc.scm log level. I tracked it down to
commits 42b6fb9 and b3a4cd6 from last July. The actual bug is trivial
(they test for the log level for "gnc" instead of "gnc.scm") but I
wonder if b3a4cd6
