Re: [GNC-dev] Sample Report with Examples

2023-03-05 Thread flywire
Highlighting minor docs tweak which the string freeze might affect: https://github.com/Gnucash/gnucash-docs/pull/299 ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] Sample Report with Examples

2023-02-01 Thread flywire
Thanks to the community for all the help with https://github.com/Gnucash/gnucash/pull/1524 It's a new report with a new guid. If everything is ok I'll update the docs as noted before and hello-world.scm can be removed. On Tue, 17 Jan 2023 at 04:55, Geert Janssens wrote: > >10. > [raised pre

Re: [GNC-dev] Sample Report with Examples

2023-01-18 Thread flywire
Frank H. Ellenberger wrote: > Did you also adjust test-stress-options? > Ahh, you mean, "You also need to adjust test-stress-options.". Can you link me to the test line in the repo? I'm not clear where it is from the log file. The PR changes a lot of strings and I get the impression they are fai

Re: [GNC-dev] Sample Report with Examples

2023-01-16 Thread Geert Janssens
Hi, See answers in between. Op zondag 15 januari 2023 23:38:07 CET schreef flywire: > This exercise has left me with a few questions about > https://github.com/flywire/gnucash/blob/Hello/gnucash/report/reports/example > /options-example.scm > >1. I'm not clear on the scheme terminology. What

Re: [GNC-dev] Sample Report with Examples

2023-01-15 Thread Michael or Penny Novack
Let me ask you, have you ever coded for a non-procedural language? If not, if scheme is your first, there is going to beĀ  learning curve, and much of your experience with procedural languages not as much help as you might think. I'd suggest you get an elementary LISP text (scheme is a dialect

Re: [GNC-dev] Sample Report with Examples

2023-01-15 Thread flywire
This exercise has left me with a few questions about https://github.com/flywire/gnucash/blob/Hello/gnucash/report/reports/example/options-example.scm 1. I'm not clear on the scheme terminology. What are the lines in the top-level definitions I labelled initialise values? I understand they ar

Re: [GNC-dev] Sample Report with Examples

2023-01-15 Thread flywire
john wrote: > I suggest: > Worth a review on my fork. I'm not sure if version or report-guid should be updated. Frank H. Ellenberger wrote: > Did you also adjust test-stress-options? > No, only changed four lines in hello-world.scm after a Sync-fork. Sometimes git has a mean streak. __

Re: [GNC-dev] Sample Report with Examples

2023-01-14 Thread Geert Janssens
All good suggestions. Let's see how many are reasonable for flywire to pick up and fix. (flywire, I have no idea of your skill level and willingness to work on this...) I would already take partial fixes as a step in the good direction. Regards, Geert Op zaterdag 14 januari 2023 16:58:09 CET

Re: [GNC-dev] Sample Report with Examples

2023-01-14 Thread john
Geert, Roger. The problem with that argument is that someone with that little programming experience isn't going to be able to write a custom report anyway. Even someone with enough programming experience to agree that default option values aren't significant to the structure of the code isn't

Re: [GNC-dev] Sample Report with Examples

2023-01-14 Thread Frank H. Ellenberger
Hi again, Am 14.01.23 um 13:19 schrieb flywire: I've made that change in my fork as well Did you also adjust test-stress-options? if failed in your previous PR. See e.g. https://github.com/Gnucash/gnucash/actions/runs/3909419637/jobs/6688757781 Regards Frank

Re: [GNC-dev] Sample Report with Examples

2023-01-14 Thread Frank H. Ellenberger
Hi, Am 14.01.23 um 13:19 schrieb flywire: renamed file to sample-report.scm. perhaps options-sample.scm would fit better? ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [GNC-dev] Sample Report with Examples

2023-01-14 Thread flywire
Geert Janssens wrote: > I'd rather use values like "Sample string", "Sample Document Title" and > "Sample Report" > I've made that change in my fork as well as changed section to Sample! and renamed file to sample-report.scm. It looks good and not like a kludge. I'd also suggest: * minor format f

Re: [GNC-dev] Sample Report with Examples

2023-01-14 Thread Geert Janssens
Ok, I tend to agree partially with flywire on this one. John, you and I have years of programming experience and to us the default value of an option is a minor detail. However I can imagine someone with hardly any development experience at all will have a much harder time to map the same str

Re: [GNC-dev] Sample Report with Examples

2023-01-13 Thread john
> On Jan 13, 2023, at 6:46 PM, flywire wrote: > > The point is not about the changes options make to reports, it's about how > the report source code changes the report and report options. Why wouldn't > unique string values help people unfamiliar with reports see the relationship > more cl

Re: [GNC-dev] Sample Report with Examples

2023-01-13 Thread flywire
I understand you didn't appreciate the post was about the PR just submitted, not the linked and quoted post 16 months earlier foreshadowing the PR for context. No concerns had been raised so there was no reason to provide the detail given until your comment. There is still scope for discussion. Jo

Re: [GNC-dev] Sample Report with Examples

2023-01-13 Thread John Ralls
> On Jan 13, 2023, at 2:07 PM, flywire wrote: > > John, Can you explain why the PR is a dumb idea? > > Comments on customising reports normally say the process is not easy. Getting > the relationships of some of the data right can be complex but well-presented > documentation and code make

Re: [GNC-dev] Sample Report with Examples

2023-01-13 Thread flywire
John, Can you explain why the PR is a dumb idea? Comments on customising reports normally say the process is not easy. Getting the relationships of some of the data right can be complex but well-presented documentation and code make it a lot easier. Report documentation is fairly well limited to

Re: [GNC-dev] Sample Report with Examples

2023-01-13 Thread john
You can't possibly be serious. Regards, John Ralls > On Jan 13, 2023, at 12:11 AM, flywire wrote: > > https://lists.gnucash.org/pipermail/gnucash-devel/2021-September/045939.html >> The code would be easier to follow if different strings other than Hello, > World! were used, making it clearer w

Re: [GNC-dev] Sample Report with Examples

2023-01-13 Thread flywire
https://lists.gnucash.org/pipermail/gnucash-devel/2021-September/045939.html > The code would be easier to follow if different strings other than Hello, World! were used, making it clearer what they relate to. While this report might have developed from a Hello World example, a minimal program to g

[GNC-dev] Sample Report with Examples

2021-09-01 Thread flywire
The Sample Report with Examples is one of those gems in GnuCash that take a bit of finding but it's well worthwhile working through it when you do. I'd like to see the first paragraph changed to emphasise its purpose and add the wiki reference in the second paragraph. Something like: > This report