Re: [PATCH] Updated add/edit account window

2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > It would definitely be nice to show selection state with checkboxes. > But it'd also be nice to use the static account types tree model. > > What do you think about this:? > > Keep the selection state private to the filterBy dialog instead of > usin

Re: [PATCH] Updated add/edit account window

2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Thu, Jan 19, 2006 at 09:31:54PM +0100, Eskil Bylund wrote: > > 2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > > > On Thu, Jan 19, 2006 at 08:19:14PM +0100, Eskil Bylund wrote: > > > > > Only

Re: [PATCH] Updated add/edit account window

2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Thu, Jan 19, 2006 at 08:19:14PM +0100, Eskil Bylund wrote: > > > Only that the static tree model probably shouldn't contain selection > > > state. It might be shared by multiple views that want different &g

Re: [PATCH] Updated add/edit account window

2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Thu, Jan 19, 2006 at 07:21:49PM +0100, Eskil Bylund wrote: > > While we're at GncTreeModelAccountTypes, there are some other changes > > I would like to make. > > 1. Remove gnc_tree_model_account_types_get/set_

Re: [PATCH] Updated add/edit account window

2006/1/19, Chris Shoemaker <[EMAIL PROTECTED]>: > On Wed, Jan 18, 2006 at 02:10:28PM +0100, Eskil Bylund wrote: > > 2006/1/17, Chris Shoemaker <[EMAIL PROTECTED]>: > > > If you want to continue with this, here's what I suggest: > > > > > > 1)

[PATCH] Remove unnecessary code

Hi, Here's a patch that removes some unnecessary code from the budget plugin page. ChangeLog: src/gnome/gnc-plugin-page-budget.c: Remove unnecessary filtering code. Account type filtering is handled by GncTreeViewAccount. Regards, Eskil Index: src/gnome/gnc-plugin-page-budget.c =

[PATCH] Enable cut and paste

Hi, Here's a patch that implements cut and paste (for widgets implementing GtkEditable, i.e. the register still uses its own code for this). It's based on code from Epiphany. (OK, I admit, I just copied it ;-) ) Regards, Eskil Index: src/gnome-utils/gnc-main-window.c =

Re: [PATCH] Updated add/edit account window

2006/1/17, Chris Shoemaker <[EMAIL PROTECTED]>: > If you want to continue with this, here's what I suggest: > > 1) move the filter function into gnc-tree-model-account-types.c. I > think it can be private because... > 2) add a public convenience routine to > gnc-tree-model-account-types.[ch] t