Re: [PATCH] Windows Build Process Tweaks

2008-04-21 Thread Daniel Harding
Andreas Köhler wrote: Hi Daniel, Am Montag, den 21.04.2008, 19:51 +0430 schrieb Daniel Harding: > Feel free to commit any of these that would be generally useful. Please revisit AUTHORS and consider dropping us a line. Here you go (I've had a few bugfix patches go in alrea

[PATCH] Windows Build Process Tweaks

2008-04-21 Thread Daniel Harding
ld be generally useful. Cheers, -Daniel Harding === packaging/win32/install.sh == --- packaging/win32/install.sh (revision 15242) +++ packaging/win32/install.sh (revision 15243) @@ -1051,7 +1051,7 @@ _CHM_LANG=$2 e

Re: Request for review: patch for bug 499496

2007-12-27 Thread Daniel Harding
Derek Atkins wrote: Hi, Daniel Harding <[EMAIL PROTECTED]> writes: Hello, I have put together a patch for a bug I filed a few weeks back. This is my first attempt to make any real changes to the GnuCash sources, so I'd appreciate feedback on both my approach to addressing the b

Re: Patch: define properties for gnc_commodity

2007-12-26 Thread Daniel Harding
Phil Longstaff wrote: > The attached patch (from svn diff) adds GObject property definitions > to the gnc_commodity object. > Couple of notes: The usage_count field of the gnc_commodity structure (exposed by your patch as PROP_REFCOUNT) is an internal field for bookkeeping and shouldn't be expos

make check on Windows [WAS Re: 16690 breaks `make check`]

2007-12-25 Thread Daniel Harding
Derek Atkins wrote: > Quoting Daniel Harding <[EMAIL PROTECTED]>: > > > Found a build problem, at least on Windows. The Makefile attempts to > > create links to several .scm files from the build directory to the > > source directory. Because Windows filesy

Re: 16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

2007-12-25 Thread Daniel Harding
[resending to the list, because I realized my original reply went only to Andrew] Andrew Sackville-West wrote on 24 Dec 2007 9:12 PM: On Mon, Dec 24, 2007 at 03:04:00PM +0430, Daniel Harding wrote: Andrew Sackville-West wrote: On Sun, Dec 23, 2007 at 11:19:42PM -0800, Andrew

Request for review: patch for bug 499496

2007-12-19 Thread Daniel Harding
Hello, I have put together a patch for a bug I filed a few weeks back. This is my first attempt to make any real changes to the GnuCash sources, so I'd appreciate feedback on both my approach to addressing the bug, as well as the format/style of the changes themselves. I've attached the patch

Tweak for Windows gnucash.bat files

2007-12-19 Thread Daniel Harding
Hello, I noticed a minor issue with the gnucash.bat files used to launch GnuCash on Windows (both the one that gets created by the installer and the one that gets generated by the build). In particular, they prepend several paths to the PATH environment variable. When the batch file is invo

[patch] Fixes for commodity debug logging

2007-11-21 Thread Daniel Harding
ve not yet filed bugs on these issues. If that would be helpful I can do so. Daniel Harding Index: engine/gnc-commodity.c === --- engine/gnc-commodity.c (revision 16596) +++ engine/gnc-commodity.c (working copy) @@ -37