Re: dist target differences between cmake and autotools

2017-07-09 Thread John Ralls
> On Jul 9, 2017, at 1:17 PM, Geert Janssens wrote: > > Hi, > > I have tested the dist target in both cmake and autotools. I couldn't test > the > autotools dist generated by cmake because my autotools is too recent. So I > have one tarball purely cmake and one tarball purely autotools. > >

Re: build after last update

2017-07-09 Thread Alex Aycinena
On Sun, Jul 9, 2017 at 1:28 PM, Alex Aycinena wrote: > > > On Sun, Jul 9, 2017 at 8:31 AM, Alex Aycinena > wrote: > >> >> >> On Sun, Jul 9, 2017 at 3:51 AM, Geert Janssens < >> geert.gnuc...@kobaltwit.be> wrote: >> >>> I had the same issue here and I've just pushed a fix. >>> >>> It turns out ou

Re: build after last update

2017-07-09 Thread Alex Aycinena
On Sun, Jul 9, 2017 at 8:31 AM, Alex Aycinena wrote: > > > On Sun, Jul 9, 2017 at 3:51 AM, Geert Janssens > wrote: > >> I had the same issue here and I've just pushed a fix. >> >> It turns out our cmake config files use a different check for packages >> based >> on the version of cmake itself. I

Re: Gtk3

2017-07-09 Thread Geert Janssens
On zondag 9 juli 2017 18:32:40 CEST Robert Fewell wrote: > I have just issued a pull request for the changes that I made after Geert > had copied my branch and most of the changes he pointed out on his review. > The main ones being the missed alt key combination on some buttons, migrate > the dialo

Re: Gtk3

2017-07-09 Thread Robert Fewell
I have just issued a pull request for the changes that I made after Geert had copied my branch and most of the changes he pointed out on his review. The main ones being the missed alt key combination on some buttons, migrate the dialog-import.glade to gtk3 again which stops a crash if you go to pre

Re: build after last update

2017-07-09 Thread Alex Aycinena
On Sun, Jul 9, 2017 at 3:51 AM, Geert Janssens wrote: > I had the same issue here and I've just pushed a fix. > > It turns out our cmake config files use a different check for packages > based > on the version of cmake itself. I presume there was a bug in cmake 3.1-3.4 > that made this necessary.

Re: build after last update

2017-07-09 Thread Geert Janssens
I had the same issue here and I've just pushed a fix. It turns out our cmake config files use a different check for packages based on the version of cmake itself. I presume there was a bug in cmake 3.1-3.4 that made this necessary. The default cmake fails on the "OPTIONAL" modifier. where the c