Re: r22464 - gnucash/trunk/src/backend/dbi/test - Enable and correct all store-and-reload basic tests

2012-10-28 Thread John Ralls
On Oct 28, 2012, at 5:05 PM, Alex Aycinena wrote: > On Sun, Oct 28, 2012 at 4:57 PM, John Ralls > wrote: >> >> On Oct 28, 2012, at 4:39 PM, Alex Aycinena wrote: >> >>> John, >>> >>> Is 'make check' working for you? It is failing for me on a clean build >>> in src/backend/dbi/test/ for r2247

Re: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely handle having g_object_property_set called on

2012-10-28 Thread John Ralls
On Oct 28, 2012, at 4:44 PM, Phil Longstaff wrote: > Does the caller have any indication that nothing was done? Well, it gets an empty GValue. It's pretty common for SXes to have empty (and therefore invalid) end-dates and last-dates, so it's not an error, critical or otherwise. I think that

Re: r22464 - gnucash/trunk/src/backend/dbi/test - Enable and correct all store-and-reload basic tests

2012-10-28 Thread Alex Aycinena
On Sun, Oct 28, 2012 at 4:57 PM, John Ralls wrote: > > On Oct 28, 2012, at 4:39 PM, Alex Aycinena wrote: > >> John, >> >> Is 'make check' working for you? It is failing for me on a clean build >> in src/backend/dbi/test/ for r22473. >> > Alex, > > Well, it did just before I committed those change

Re: r22464 - gnucash/trunk/src/backend/dbi/test - Enable and correct all store-and-reload basic tests

2012-10-28 Thread John Ralls
On Oct 28, 2012, at 4:39 PM, Alex Aycinena wrote: > John, > > Is 'make check' working for you? It is failing for me on a clean build > in src/backend/dbi/test/ for r22473. > Alex, Well, it did just before I committed those changes. But I was working in trunk, and r22473 is 2.4. Which one are

Re: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely handle having g_object_property_set called on

2012-10-28 Thread Phil Longstaff
Does the caller have any indication that nothing was done? From: John Ralls To: Phil Longstaff Cc: "gnucash-devel@gnucash.org devel" Sent: Sunday, October 28, 2012 7:02:53 PM Subject: Re: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely hand

Re: r22464 - gnucash/trunk/src/backend/dbi/test - Enable and correct all store-and-reload basic tests

2012-10-28 Thread Alex Aycinena
John, Is 'make check' working for you? It is failing for me on a clean build in src/backend/dbi/test/ for r22473. Regards, Alex On Sat, Oct 27, 2012 at 4:30 PM, John Ralls wrote: > Author: jralls > Date: 2012-10-27 19:30:40 -0400 (Sat, 27 Oct 2012) > New Revision: 22464 > Trac: http://svn.gnuc

Re: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely handle having g_object_property_set called on

2012-10-28 Thread John Ralls
On Oct 28, 2012, at 11:51 AM, Phil Longstaff wrote: > How about an else clause in case the value is invalid? If it's invalid, it does nothing. What would you like it to do? Regards, John Ralls > > > > From: John Ralls > To: gnucash-patc...@gnucash.org > Se

Re: OT - 1000 commits

2012-10-28 Thread Ngewi Fet
Congrats. Here' to the next thousand! On Sun, Oct 28, 2012 at 7:50 PM, Geert Janssens wrote: > According to ohloh, I just reached a personal milestone of 1000 commits in > the gnucash source tree. Yay ! > > Of course it's not an important metric, but it was fun to discover anyway > :) I'm also we

Re: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely handle having g_object_property_set called on

2012-10-28 Thread Phil Longstaff
How about an else clause in case the value is invalid? From: John Ralls To: gnucash-patc...@gnucash.org Sent: Saturday, October 27, 2012 7:30:57 PM Subject: r22465 - gnucash/trunk/src/engine - Allow SchedXaction to safely handle having g_object_property_set ca

OT - 1000 commits

2012-10-28 Thread Geert Janssens
According to ohloh, I just reached a personal milestone of 1000 commits in the gnucash source tree. Yay ! Of course it's not an important metric, but it was fun to discover anyway :) I'm also well aware that some of these commits are patches sent in by others, so it's my improvements alone tha

Re: Gnucash documentation

2012-10-28 Thread Geert Janssens
On 29-09-12 11:54, Cristian Marchi wrote: I'm currently working on the bug you pointed out and I hope to have it finalized and translated to Italian in some days. I will let you know when I'm done. Thanks for waiting for me again! The patch for that bug will apply to 2.4 and trunk. Can you ple