Re: [PATCH] Fix generic import skipped transactions

2009-02-10 Thread David Reiser
On Feb 10, 2009, at 9:14 AM, Alan Jenkins wrote: > Sorry, bad commit description. Here's the corrected version. >> From b4f28335d813aa5c0a32802610f8cc48e2345eb5 Mon Sep 17 00:00:00 >> 2001 > From: Alan Jenkins > Date: Tue, 10 Feb 2009 14:13:14 + > Subject: [PATCH] Fix generic import skipp

Re: [PATCH] Repair automatch_store_transactions

2009-02-10 Thread David Reiser
[snip] Are you sure that the first deposit gets reassigned in the case where it is a manual deposit? The matching code clearly attempts to avoid matching transactions that were manually set (in import-backend.c at gnc_import_TransInfo_refresh_destacc). >>> >>> Yes,

Re: Windows packaging: upgrade to gtk 2.14.7?

2009-02-10 Thread Charles Day
On Mon, Feb 9, 2009 at 9:58 PM, Andreas Köhler wrote: > Hi Charles, > > sure, that is perfectly possible. Simply point the URLs in > packaging/win32/defaults.sh to the correct files {,-dev} in > ftp://ftp.gnome.org/pub/gnome/binaries/win32/gtk+/2.14/. > > OTOH, we are talking about Bug #520165,

Re: Transaction API question

2009-02-10 Thread Charles Day
On Tue, Feb 10, 2009 at 12:27 PM, Alan Jenkins wrote: > Christian Stimming wrote: > > Am Dienstag, 10. Februar 2009 11:02 schrieb Alan Jenkins: > > > I have a question about how to destroy a transaction properly. > > >> Interesting. The generic import layer does this: > >> > >> xaccTran

Re: [PATCH] Fix generic import skipped transactions

2009-02-10 Thread Christian Stimming
Applied. Thanks a lot for this bugfix! No idea why I never checked for the TransInfo destructor, but thanks for fixing this one. Christian Am Dienstag, 10. Februar 2009 15:14 schrieb Alan Jenkins: > Sorry, bad commit description. Here's the corrected version. ___

Re: [PATCH] Fix typos in comments

2009-02-10 Thread Christian Stimming
Applied. Thank! ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [PATCH] Store online_id in split instead of transaction to avoid import conflicts

2009-02-10 Thread Christian Stimming
Applied. Thanks a lot! ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: [PATCH] Correct english in generic-import-design.txt

2009-02-10 Thread Christian Stimming
Applied, thanks! ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: Completed Catalan translation to commit

2009-02-10 Thread Christian Stimming
Am Dienstag, 10. Februar 2009 00:28 schrieb David Planella: > Derek's suggestion would be an improvement, but before starting > something new, I'd like to ask another question. I apologise if this > has already been discussed here before, :-) No problem. Indeed this particular proposal has been br

Re: Transaction API question

2009-02-10 Thread Christian Stimming
Am Dienstag, 10. Februar 2009 11:02 schrieb Alan Jenkins: > >> I have a question about how to destroy a transaction properly. > > Interesting. The generic import layer does this: > > xaccTransDestroy(trans); > xaccTransCommitEdit(trans); > > to destroy an open transaction in gnc_import_exists_onl

Re: [PATCH] Fix generic import skipped transactions

2009-02-10 Thread Alan Jenkins
Sorry, bad commit description. Here's the corrected version. >From b4f28335d813aa5c0a32802610f8cc48e2345eb5 Mon Sep 17 00:00:00 2001 From: Alan Jenkins Date: Tue, 10 Feb 2009 14:13:14 + Subject: [PATCH] Fix generic import skipped transactions gnc_import_TransInfo_delete() was defined but nev

[PATCH] Fix generic import skipped transactions

2009-02-10 Thread Alan Jenkins
>From cd4498c0a8d61be4b0f9d55f30d429da68c89d80 Mon Sep 17 00:00:00 2001 From: Alan Jenkins Date: Tue, 10 Feb 2009 13:58:52 + Subject: [PATCH] Fix generic import skipped transactions Bug 552275 - Cancelling OFX Import Still Adds Entries Bug 434944 - Refused transactions from import appear in

Re: Transaction API question

2009-02-10 Thread Alan Jenkins
On 2/10/09, Charles Day wrote: > On Thu, Jan 29, 2009 at 10:28 AM, Charles Day wrote: > >> I have a question about how to destroy a transaction properly. Suppose I >> do >> the following to create a new transaction with one split. >> >> new_trans = xaccMallocTransaction (gnc_get_current_book

Re: Converting iso-4217-currencies.scm to C?

2009-02-10 Thread Alan Jenkins
Derek Atkins wrote: > Christian Stimming writes: > > >> Right now we have a scheme -> C generator that generates a list of 3000 >> function calls. I think Alan's proposal was to change this into a generator >> that generates a C array with 3000 entries, and writing some simple looping >> cod