Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-08 Thread Johan Cwiklinski
Hello, > I propose new coding methods to enhance GLPI (better code, have > tests, so less bugs): > [...] Two points I'd like to talk about :) 1- And what about a clear GIT worflow? For some projects, I've already used git-flow (http://nvie.com/posts/a-successful-git-branching-model/); mainly b

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-08 Thread Alexandre Delaunay
Thanks for your message and suggestions. I really appreciate. For most of theses points, i agree. - For systematic PR, we could add this process quickly. It concerns a few developers (mainly me, but also Walid, Yllen & Remi). We pushed directly to master for convenience. Also, number of external

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-08 Thread David DURIEUX
Le Thu, 8 Sep 2016 12:24:02 +0200 (CEST) Alexandre Delaunay a écrit: >Thanks for your message and suggestions. >I really appreciate. > >For most of theses points, i agree. >- For systematic PR, we could add this process quickly. It concerns a >few developers (mainly me, but also Walid, Yllen & Re