@Pynckels pushed 1 commit.
e564f4a1b68e24f8d2e278b96e25ea9156adc764 Add %d %e %p to print_external, align
meaning of %f with build
--
View it on GitHub:
https://github.com/geany/geany/pull/4250/files/5f3536455d689a3d234b94ae63563fe3fd3c7a3f..e564f4a1b68e24f8d2e278b96e25ea9156adc764
You are rec
@Pynckels commented on this pull request.
> + gchar *executable = NULL;
+ gchar *replacement = NULL;
+ gintline_num = 0;
+ GRegex *regex = NULL;
+ GString *errormsg= NULL;
+
+ g_return_val_if_fail(doc != NULL, NULL);
+ g_return_
@Pynckels pushed 1 commit.
d6c957a48604acbb1d6917949d6635c8ad6544df Add %d %e %p to print_external, align
meaning of %f with build
--
View it on GitHub:
https://github.com/geany/geany/pull/4250/files/e564f4a1b68e24f8d2e278b96e25ea9156adc764..d6c957a48604acbb1d6917949d6635c8ad6544df
You are rec
Pynckels left a comment (geany/geany#4250)
Changes are applied. Ready to squash and merge.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4250#issuecomment-2799928982
You are receiving this because you are subscribed to this thread.
Message ID:
Reopened #4250.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4250#event-17391582155
You are receiving this because you are subscribed to this thread.
Message ID:
@Pynckels pushed 0 commits.
--
View it on GitHub:
https://github.com/geany/geany/pull/4250/files/060f38fa7e4155a1c77a915a328f3b75f87f83d7..7833f640114bc4596d52c2575cace99202aa1102
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #4250.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/4250#event-17391423489
You are receiving this because you are subscribed to this thread.
Message ID:
Pynckels left a comment (geany/geany#4250)
I have aligned my branch (print-external) with the geany/geany/master branch
and applied all changes in a single commit. You can do a pull of the single
commit.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull
Pynckels left a comment (geany/geany#4250)
I have refactored printing.c It calls a function utils_replace_placeholder in
utils.c (declared in utils.h)
The call looks like:
(void) utils_replace_placeholder(&cmdline, "defp", doc->file_name);
(void) at start to ignore the return code explicitly.
@Pynckels pushed 1 commit.
9035db4173813dbbf86174af6b7dbba0b608caae Add %d %e %p to print_external, align
meaning of %f with build
--
View it on GitHub:
https://github.com/geany/geany/pull/4250/files/3ed3845d543fb9e3e8a3f10a0d1cff67a274559a..9035db4173813dbbf86174af6b7dbba0b608caae
You are rec
@Pynckels pushed 1 commit.
4b2229598b2bc3eb733c3a04a41b86bf12c8e53b Add %d %e %p to print_external, align
meaning of %f with build
--
View it on GitHub:
https://github.com/geany/geany/pull/4250/files/9035db4173813dbbf86174af6b7dbba0b608caae..4b2229598b2bc3eb733c3a04a41b86bf12c8e53b
You are rec
Dear Geany-team,
I have **_added functionality_** to `print_external`. More specific, I have
included/aligned most of the replacements that are present in the build dialog
box:
- replace `%d` with the absolute path
- replace `%e` with the filename (excluding extension)
- replace `%f` with the f
@Pynckels pushed 1 commit.
e742c67a6a97309a83e3f00893cf9b881833c4ed Merge branch 'geany:master' into
print-external
--
View it on GitHub:
https://github.com/geany/geany/pull/4250/files/6d683385a7df0a31087ffcb63d58443966539853..e742c67a6a97309a83e3f00893cf9b881833c4ed
You are receiving this bec
Pynckels left a comment (geany/geany#4250)
utils_replace_placeholder has not the same functionality:
* No %l replacement, because it makes no sense in the context of printing.
Using a routine than can do more than it should do seems an open invitation for
logic errors. What is the result of the
@Pynckels pushed 1 commit.
5f3536455d689a3d234b94ae63563fe3fd3c7a3f Add %d %e %p to print_external, align
meaning of %f with build
--
View it on GitHub:
https://github.com/geany/geany/pull/4250/files/e742c67a6a97309a83e3f00893cf9b881833c4ed..5f3536455d689a3d234b94ae63563fe3fd3c7a3f
You are rec
Pynckels left a comment (geany/geany#4250)
Up until now:
**_New `utils_replace_placeholder`_**
Reason: to get a functional logic that can be used from build.c as well as
printing.c some changes were necessary. For instance: build can use the
placeholder %l, on the other hand this placeholder d
@Pynckels commented on this pull request.
> @@ -593,8 +593,8 @@ static void print_external(GeanyDocument *doc)
return;
}
- cmdline = g_strdup(printing_prefs.external_print_cmd);
- utils_str_replace_all(&cmdline, "%f", doc->file_name);
+ /* replace d, e
17 matches
Mail list logo
