alamb opened a new issue, #10580:
URL: https://github.com/apache/datafusion/issues/10580
### Is your feature request related to a problem or challenge?
It is common in databases and other analytic system to have additional
external "indexes" (perhaps stored in the "metadata catalog",
alamb merged PR #3:
URL: https://github.com/apache/datafusion-site/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.
alamb commented on PR #3:
URL: https://github.com/apache/datafusion-site/pull/3#issuecomment-2120752894
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
alamb commented on issue #10565:
URL: https://github.com/apache/datafusion/issues/10565#issuecomment-2120754098
Thank you @jayzhan211 🙏 -- I will review it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
alamb commented on code in PR #10568:
URL: https://github.com/apache/datafusion/pull/10568#discussion_r1606971468
##
datafusion/core/tests/expr_api/mod.rs:
##
@@ -61,7 +63,7 @@ fn test_eq_with_coercion() {
#[test]
fn test_get_field() {
evaluate_expr_test(
-get_fie
alamb commented on code in PR #10568:
URL: https://github.com/apache/datafusion/pull/10568#discussion_r1606978717
##
datafusion/functions/src/core/expr_ext.rs:
##
@@ -0,0 +1,68 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
Blizzara commented on code in PR #10531:
URL: https://github.com/apache/datafusion/pull/10531#discussion_r1606981891
##
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##
@@ -607,6 +608,15 @@ async fn qualified_catalog_schema_table_reference() ->
Result<()> {
r
alamb commented on issue #10557:
URL: https://github.com/apache/datafusion/issues/10557#issuecomment-2120775312
https://github.com/apache/datafusion/pull/10392 is the upgrade to sqlparser
-- I think it is pretty close but @tisonkun hit an issue during upgrade.
--
This is an automated mes
alamb commented on issue #2703:
URL: https://github.com/apache/datafusion/issues/2703#issuecomment-2120780299
Hi @leoluan2009
In my opinion, I don't think DataFusion needs JIT to get good performance.
In general, I find the paper ["Everything You Always Wanted to Know About
C
timsaucer commented on code in PR #710:
URL: https://github.com/apache/datafusion-python/pull/710#discussion_r1606991649
##
.github/workflows/test.yaml:
##
@@ -111,3 +134,9 @@ jobs:
source venv/bin/activate
pip install -e . -vv
pytest -v .
+
+
timsaucer commented on code in PR #710:
URL: https://github.com/apache/datafusion-python/pull/710#discussion_r1606991649
##
.github/workflows/test.yaml:
##
@@ -111,3 +134,9 @@ jobs:
source venv/bin/activate
pip install -e . -vv
pytest -v .
+
+
tisonkun commented on code in PR #10392:
URL: https://github.com/apache/datafusion/pull/10392#discussion_r1605950326
##
datafusion/sqllogictest/test_files/array.slt:
##
Review Comment:
Can be a bug after the JSON path parse changes -
https://github.com/sqlparser-rs/sqlpars
tisonkun commented on issue #10557:
URL: https://github.com/apache/datafusion/issues/10557#issuecomment-2120801283
> #10392 is the upgrade to sqlparser -- I think it is pretty close but
@tisonkun hit an issue during upgrade.
We may need a 0.46.1 for resolving the regressions:
*
parthchandra opened a new issue, #452:
URL: https://github.com/apache/datafusion-comet/issues/452
### Describe the bug
ExtendedExplainInfo is declared as a class, but it can be an object instead.
### Steps to reproduce
_No response_
### Expected behavior
_N
parthchandra commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1607016398
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,23 @@ class CometSparkSessionExtensions
} else {
andygrove commented on PR #2:
URL:
https://github.com/apache/datafusion-benchmarks/pull/2#issuecomment-2120828494
Thanks for the review @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
andygrove merged PR #2:
URL: https://github.com/apache/datafusion-benchmarks/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
kazuyukitanimura commented on code in PR #451:
URL: https://github.com/apache/datafusion-comet/pull/451#discussion_r1607045862
##
spark/src/test/scala/org/apache/comet/DataGenerator.scala:
##
@@ -95,4 +102,55 @@ class DataGenerator(r: Random) {
Range(0, n).map(_ => r.next
alamb commented on code in PR #10575:
URL: https://github.com/apache/datafusion/pull/10575#discussion_r1607048271
##
datafusion/expr/src/logical_plan/extension.rs:
##
@@ -76,27 +76,20 @@ pub trait UserDefinedLogicalNode: fmt::Debug + Send + Sync {
/// For example: `TopK: k=
alamb commented on PR #10577:
URL: https://github.com/apache/datafusion/pull/10577#issuecomment-2120882095
I'll leave this open for a day as it is an API change, in case anyone else
wants a chance to review
--
This is an automated message from the Apache Git Service.
To respond to the mes
comphead merged PR #10578:
URL: https://github.com/apache/datafusion/pull/10578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb commented on PR #10564:
URL: https://github.com/apache/datafusion/pull/10564#issuecomment-2120885272
@jayzhan211 has a better fix in
https://github.com/apache/datafusion/pull/10568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb closed pull request #10564: Minor: Fix name in ArrayFunctionRewriter,
error not panic if `Expr::GetStructField` is planned
URL: https://github.com/apache/datafusion/pull/10564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
comphead commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1607055206
##
datafusion/sql/Cargo.toml:
##
@@ -47,6 +47,7 @@ arrow-schema = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafus
alamb opened a new pull request, #10581:
URL: https://github.com/apache/datafusion/pull/10581
This confused me while debugging something else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
alamb commented on code in PR #10567:
URL: https://github.com/apache/datafusion/pull/10567#discussion_r1607060754
##
datafusion/optimizer/src/push_down_filter.rs:
##
@@ -861,16 +861,12 @@ impl OptimizerRule for PushDownFilter {
.collect();
l
alamb merged PR #10558:
URL: https://github.com/apache/datafusion/pull/10558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #10550: Add an example of how to convert LogicalPlan to/from
SQL Strings
URL: https://github.com/apache/datafusion/issues/10550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
comphead commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1607067858
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -504,6 +508,14 @@ impl Unparser<'_> {
.collect::>>()
}
+pub(super) fn new_ident_quoted_if_ne
alamb commented on code in PR #10582:
URL: https://github.com/apache/datafusion/pull/10582#discussion_r1607076013
##
datafusion-examples/examples/plan_to_sql.rs:
##
@@ -22,36 +22,45 @@ use datafusion::sql::unparser::expr_to_sql;
use datafusion_sql::unparser::dialect::CustomDial
viirya opened a new issue, #10583:
URL: https://github.com/apache/datafusion/issues/10583
### Describe the bug
During working on https://github.com/apache/datafusion-comet/pull/437, a few
Spark join tests are failed when delegating to DataFusion HashJoin.
It is because that Dat
viirya opened a new pull request, #10584:
URL: https://github.com/apache/datafusion/pull/10584
## Which issue does this PR close?
Closes #10583.
## Rationale for this change
## What changes are included in this PR?
## Are these changes teste
viirya commented on PR #10584:
URL: https://github.com/apache/datafusion/pull/10584#issuecomment-2120931328
Added the test case first. I will find some time to work on the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
viirya commented on code in PR #10584:
URL: https://github.com/apache/datafusion/pull/10584#discussion_r1607085982
##
datafusion/sqllogictest/test_files/join.slt:
##
@@ -793,3 +793,19 @@ DROP TABLE companies
statement ok
DROP TABLE leads
+
+
+# LeftAnti Join with null
+state
alamb commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607087345
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,652 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607091830
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,652 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607104678
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,652 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb opened a new issue, #10585:
URL: https://github.com/apache/datafusion/issues/10585
### Describe the bug
As @NGA-TRAN found in https://github.com/apache/datafusion/pull/10537 when
i8 and i16 values are written to parquet and then the statistics are extracted,
the returned min/m
NGA-TRAN commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607104991
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,652 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
alamb commented on issue #10585:
URL: https://github.com/apache/datafusion/issues/10585#issuecomment-2120956336
Possibly related to https://github.com/apache/datafusion/issues/9779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
alamb commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607107595
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,652 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607110465
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,652 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb opened a new issue, #10586:
URL: https://github.com/apache/datafusion/issues/10586
### Describe the bug
As @tustvold points out, there is a [`column_order`
API](https://docs.rs/parquet/latest/parquet/file/metadata/struct.FileMetaData.html#method.column_order)
defined in parquet
alamb commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607118413
##
datafusion/core/src/datasource/physical_plan/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,43 @@
+use arrow_array::ArrayRef;
+use arrow_schema::DataType;
+use datafu
alamb opened a new issue, #10587:
URL: https://github.com/apache/datafusion/issues/10587
### Describe the bug
When reading a Date32 or Date64 column from a parquet file, DataFusion
currently returns an Int32 array
### To Reproduce
You can see the issue in https:/
alamb commented on code in PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#discussion_r1607125587
##
datafusion/core/tests/parquet/arrow_statistics.rs:
##
@@ -0,0 +1,654 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb commented on PR #10537:
URL: https://github.com/apache/datafusion/pull/10537#issuecomment-2120986025
I have filed the following tickets
* https://github.com/apache/datafusion/issues/10585
* https://github.com/apache/datafusion/issues/10586
* #10587
I think this PR is
twitu closed issue #10572: Row groups are read out of order or with completely
different values
URL: https://github.com/apache/datafusion/issues/10572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
edmondop commented on code in PR #10582:
URL: https://github.com/apache/datafusion/pull/10582#discussion_r1607146553
##
datafusion-examples/examples/plan_to_sql.rs:
##
@@ -22,36 +22,45 @@ use datafusion::sql::unparser::expr_to_sql;
use datafusion_sql::unparser::dialect::CustomD
alamb opened a new pull request, #10588:
URL: https://github.com/apache/datafusion/pull/10588
## Which issue does this PR close?
## Rationale for this change
In an effort to make it faster to develop and test datafusion , it would be
nice if the resources required to run th
alamb commented on code in PR #10588:
URL: https://github.com/apache/datafusion/pull/10588#discussion_r1607149443
##
datafusion/core/tests/custom_sources.rs:
##
@@ -1,308 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
This was moved to
kazuyukitanimura commented on code in PR #433:
URL: https://github.com/apache/datafusion-comet/pull/433#discussion_r1607151015
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1452,17 +1452,55 @@ class CometExpressionSuite extends CometTestBase with
A
alamb merged PR #10537:
URL: https://github.com/apache/datafusion/pull/10537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
edmondop commented on issue #10587:
URL: https://github.com/apache/datafusion/issues/10587#issuecomment-2121024857
@alamb the title here doesn't make much sense, are you saying that the `min`
and `max` are not extracted as Date32/Date64?
--
This is an automated message from the Apache Git
davisp opened a new issue, #10589:
URL: https://github.com/apache/datafusion/issues/10589
### Is your feature request related to a problem or challenge?
I've been reading and learning the TableProvider APIs and have finally
gotten around to taking a serious look at implementing suppor
kazuyukitanimura commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1607158744
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,46 @@ class CometExpressionSuite extends CometTestBase with
Ad
kazuyukitanimura commented on code in PR #422:
URL: https://github.com/apache/datafusion-comet/pull/422#discussion_r1607164180
##
docs/source/index.rst:
##
@@ -58,7 +58,11 @@ as a native runtime to achieve improvement in terms of query
efficiency and quer
Comet Plugin Overv
davisp opened a new pull request, #10590:
URL: https://github.com/apache/datafusion/pull/10590
## Which issue does this PR close?
Closes #10589
## Rationale for this change
Provide per-column key/value options in the `CREATE EXTERN TABLE` statement.
## What changes
davisp commented on PR #10590:
URL: https://github.com/apache/datafusion/pull/10590#issuecomment-2121051712
Also, for anyone more familiar with datafusion and/or sqlparser, one thing I
wasn't 100% on was how to represent the metadata value. For now I've just
called format on it, but I have
tshauck commented on code in PR #422:
URL: https://github.com/apache/datafusion-comet/pull/422#discussion_r1607185036
##
docs/source/index.rst:
##
@@ -58,7 +58,11 @@ as a native runtime to achieve improvement in terms of query
efficiency and quer
Comet Plugin Overview
tshauck commented on PR #422:
URL: https://github.com/apache/datafusion-comet/pull/422#issuecomment-2121071344
@andygrove Conflict should actually be fixed now, thanks @kazuyukitanimura
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
tshauck commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1607197818
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,46 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSpa
korowa opened a new pull request, #10591:
URL: https://github.com/apache/datafusion/pull/10591
## Which issue does this PR close?
Closes #.
## Rationale for this change
Initial intention was to improve clickbench q34 -- it contains aggregation
by constant
andygrove commented on code in PR #450:
URL: https://github.com/apache/datafusion-comet/pull/450#discussion_r1607200546
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -533,11 +533,16 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelpe
andygrove commented on code in PR #450:
URL: https://github.com/apache/datafusion-comet/pull/450#discussion_r1607203214
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -533,11 +533,16 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelpe
kazuyukitanimura commented on code in PR #450:
URL: https://github.com/apache/datafusion-comet/pull/450#discussion_r1607216900
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -533,11 +533,16 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPl
kazuyukitanimura commented on code in PR #449:
URL: https://github.com/apache/datafusion-comet/pull/449#discussion_r1607218060
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1038,6 +1038,46 @@ class CometExpressionSuite extends CometTestBase with
Ad
kazuyukitanimura commented on code in PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#discussion_r1607249542
##
spark/src/main/scala/org/apache/spark/sql/comet/DecimalPrecision.scala:
##
@@ -107,11 +108,4 @@ object DecimalPrecision {
case e => e
}
kazuyukitanimura commented on PR #407:
URL: https://github.com/apache/datafusion-comet/pull/407#issuecomment-2121165967
@viirya Please take another look
cc @andygrove @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
andygrove opened a new pull request, #453:
URL: https://github.com/apache/datafusion-comet/pull/453
## Which issue does this PR close?
Closes https://github.com/apache/datafusion-comet/issues/431
## Rationale for this change
Enable cast string to int as a
appletreeisyellow commented on code in PR #10527:
URL: https://github.com/apache/datafusion/pull/10527#discussion_r1607253589
##
datafusion/optimizer/src/single_distinct_to_groupby.rs:
##
@@ -131,177 +126,190 @@ fn contains_grouping_set(expr: &[Expr]) -> bool {
impl OptimizerRu
andygrove commented on code in PR #453:
URL: https://github.com/apache/datafusion-comet/pull/453#discussion_r1607253762
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -82,7 +82,7 @@ macro_rules! cast_utf8_to_int {
for i in 0..len {
if $array.is
andygrove commented on code in PR #453:
URL: https://github.com/apache/datafusion-comet/pull/453#discussion_r1607254539
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -1029,34 +1021,22 @@ fn do_cast_string_to_int<
type_name: &str,
min_value: T,
) -> Comet
andygrove commented on code in PR #453:
URL: https://github.com/apache/datafusion-comet/pull/453#discussion_r1607255075
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -1070,7 +1050,7 @@ fn do_cast_string_to_int<
if ch == '.' {
if eval_m
andygrove commented on code in PR #450:
URL: https://github.com/apache/datafusion-comet/pull/450#discussion_r1607255755
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -533,11 +533,16 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelpe
andygrove merged PR #422:
URL: https://github.com/apache/datafusion-comet/pull/422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
appletreeisyellow commented on code in PR #10527:
URL: https://github.com/apache/datafusion/pull/10527#discussion_r1607264284
##
datafusion/optimizer/src/single_distinct_to_groupby.rs:
##
@@ -131,177 +126,190 @@ fn contains_grouping_set(expr: &[Expr]) -> bool {
impl OptimizerRu
appletreeisyellow commented on PR #10527:
URL: https://github.com/apache/datafusion/pull/10527#issuecomment-2121182146
@alamb Thanks for the review! I have updated the code according to your
feedback
> I found whitespace blind diff easier to review: [#10527
(files)](https://github.co
alamb commented on issue #10587:
URL: https://github.com/apache/datafusion/issues/10587#issuecomment-2121184299
Thanks for pointing that out @edmondop -- yes the min/max seem to be
extracted as `Int32Array`s
--
This is an automated message from the Apache Git Service.
To respond to the m
alamb commented on PR #10543:
URL: https://github.com/apache/datafusion/pull/10543#issuecomment-2121191619
What do we think about merging this PR and filing a follow on ticket to
unify the APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
alamb commented on PR #10532:
URL: https://github.com/apache/datafusion/pull/10532#issuecomment-2121194261
I plan to incorporate the feedback on this PR, I just haven't had a chance
yet. I hope to do so over the next few days
--
This is an automated message from the Apache Git Service.
To
NGA-TRAN opened a new pull request, #10592:
URL: https://github.com/apache/datafusion/pull/10592
## Which issue does this PR close?
More tests for https://github.com/apache/datafusion/issues/10453
## Rationale for this change
## What changes are included in th
comphead merged PR #10304:
URL: https://github.com/apache/datafusion/pull/10304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead closed issue #10379: Sort Merge Join. LeftSemi issues
URL: https://github.com/apache/datafusion/issues/10379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
parthchandra commented on code in PR #395:
URL: https://github.com/apache/datafusion-comet/pull/395#discussion_r1607363360
##
common/src/main/java/org/apache/comet/parquet/CometParquetToSparkSchemaConverter.scala:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foun
parthchandra commented on PR #453:
URL: https://github.com/apache/datafusion-comet/pull/453#issuecomment-2121348910
So do you thing the perf improvement is because we are no longer trimming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
parthchandra commented on code in PR #436:
URL: https://github.com/apache/datafusion-comet/pull/436#discussion_r1607380766
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -1399,7 +1399,7 @@ class CometExpressionSuite extends CometTestBase with
Adaptiv
parthchandra opened a new issue, #454:
URL: https://github.com/apache/datafusion-comet/issues/454
### Describe the bug
Separate out extended explain info unit test into spark dependent and spark
independent parts
### Steps to reproduce
_No response_
### Expected b
parthchandra commented on issue #440:
URL:
https://github.com/apache/datafusion-comet/issues/440#issuecomment-2121399387
Is this an issue of just a mismatch between error messages? Or is the cast
actually not doing the right thing with Spark 3.2?
--
This is an automated message from the
andygrove commented on PR #453:
URL: https://github.com/apache/datafusion-comet/pull/453#issuecomment-2121447145
> So do you thing the perf improvement is because we are no longer trimming?
We are still trimming, but we are no longer performing the redundant
conditional logic in the m
huaxingao commented on code in PR #395:
URL: https://github.com/apache/datafusion-comet/pull/395#discussion_r1607409997
##
common/src/main/java/org/apache/comet/parquet/CometParquetToSparkSchemaConverter.scala:
##
@@ -0,0 +1,403 @@
+/*
+ * Licensed to the Apache Software Foundat
timsaucer commented on PR #710:
URL:
https://github.com/apache/datafusion-python/pull/710#issuecomment-2121459794
It looks like CI is running correctly and also caching the data. I’ll rebase
in the morning and get the PR ready to merge.
--
This is an automated message from the Apache Git
jayzhan211 commented on PR #10568:
URL: https://github.com/apache/datafusion/pull/10568#issuecomment-2121463057
Thanks, @alamb !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
jayzhan211 merged PR #10568:
URL: https://github.com/apache/datafusion/pull/10568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 closed issue #10374: Remove `Expr::GetIndexedField` and
`GetFieldAccess` and always use function `get_field` for indexing
URL: https://github.com/apache/datafusion/issues/10374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jayzhan211 closed issue #10565: Using `Expr::field` panics
URL: https://github.com/apache/datafusion/issues/10565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
alamb commented on issue #10314:
URL: https://github.com/apache/datafusion/issues/10314#issuecomment-2121468243
> Hi @alamb, I am trying to work on this.
>
> I am not very familiar on the `InterleaveExec` in the optimizer. As
initial thought, the interleaveExec is acting as a **Repart
alamb commented on code in PR #10392:
URL: https://github.com/apache/datafusion/pull/10392#discussion_r1607425124
##
datafusion/sqllogictest/test_files/array.slt:
##
Review Comment:
Thanks @tisonkun -- sounds like we should fix that upstream and then I can
maybe make a ne
alamb commented on PR #10304:
URL: https://github.com/apache/datafusion/pull/10304#issuecomment-2121484917
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
vaibhawvipul closed pull request #450: bug fix: Fix fuzz testcase for cast
string to integer
URL: https://github.com/apache/datafusion-comet/pull/450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
101 - 200 of 75611 matches
Mail list logo
